From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 130548 invoked by alias); 24 Jun 2015 13:56:39 -0000 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org Received: (qmail 130502 invoked by uid 48); 24 Jun 2015 13:56:36 -0000 From: "dsmith at redhat dot com" To: systemtap@sourceware.org Subject: [Bug tapsets/18571] Tapset support and test coverage for bpf and seccomp syscalls. Date: Wed, 24 Jun 2015 13:56:00 -0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: systemtap X-Bugzilla-Component: tapsets X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: dsmith at redhat dot com X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: systemtap at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2015-q2/txt/msg00202.txt.bz2 https://sourceware.org/bugzilla/show_bug.cgi?id=18571 --- Comment #2 from David Smith --- In general the patch looks fine to me. However, I'm not sure about this change: ==== - uargs = user_string_quoted($uargs) + uargs = $uargs ==== I think you are on the right path here, that is an address, not a string. However, I think you should go a bit farther, deprecate the old string usage and rename the convenience variable to 'uargs_uaddr' to make sure users know this is a user address. The code would look something like: ==== %( systemtap_v <= "2.8" %? uargs = user_string_quoted($uargs) %) uargs_uaddr = $uargs ==== You would also need to make changes when printing the argstr (using the new variable name) and update the corresponding nd_syscall code. -- You are receiving this mail because: You are the assignee for the bug.