[Bug tapsets/18571] New: Tapset support and test coverage for bpf and seccomp syscalls.

[Bug tapsets/18571] New: Tapset support and test coverage for bpf and seccomp syscalls.

[mcermak at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=18571

            Bug ID: 18571
           Summary: Tapset support and test coverage for bpf and seccomp
                    syscalls.
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: tapsets
          Assignee: systemtap at sourceware dot org
          Reporter: mcermak at redhat dot com
  Target Milestone: ---

The bpf syscall needs tapset support and test coverage. Syscall seccomp needs
test coverage.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug tapsets/18571] Tapset support and test coverage for bpf and seccomp syscalls.

[mcermak at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=18571

--- Comment #1 from Martin Cermak <mcermak at redhat dot com> ---
Created attachment 8386
  --> https://sourceware.org/bugzilla/attachment.cgi?id=8386&action=edit
proposed patch

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug tapsets/18571] Tapset support and test coverage for bpf and seccomp syscalls.

[mcermak at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=18571

Martin Cermak <mcermak at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dsmith at redhat dot com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug tapsets/18571] Tapset support and test coverage for bpf and seccomp syscalls.

[dsmith at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=18571

--- Comment #2 from David Smith <dsmith at redhat dot com> ---
In general the patch looks fine to me. However, I'm not sure about this change:

====
- uargs = user_string_quoted($uargs)
+ uargs = $uargs
====

I think you are on the right path here, that is an address, not a string.
However, I think you should go a bit farther, deprecate the old string usage
and rename the convenience variable to 'uargs_uaddr' to make sure users know
this is a user address. The code would look something like:

====
%( systemtap_v <= "2.8" %?
   uargs = user_string_quoted($uargs)
%)
   uargs_uaddr = $uargs
====

You would also need to make changes when printing the argstr (using the new
variable name) and update the corresponding nd_syscall code.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug tapsets/18571] Tapset support and test coverage for bpf and seccomp syscalls.

[mcermak at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=18571

Martin Cermak <mcermak at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Martin Cermak <mcermak at redhat dot com> ---
Fixed in commit a7396f637e7c0c9083281b562d514506c465fc02

-- 
You are receiving this mail because:
You are the assignee for the bug.