From: "dsmith at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sourceware.org
Subject: [Bug tapsets/18649] int_arg() misbehaves on x86[_64] for 32-bit uprobe in binary having debuginfo
Date: Fri, 14 Aug 2015 19:07:00 -0000 [thread overview]
Message-ID: <bug-18649-6586-X4rfxORZnT@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-18649-6586@http.sourceware.org/bugzilla/>
https://sourceware.org/bugzilla/show_bug.cgi?id=18649
--- Comment #10 from David Smith <dsmith at redhat dot com> ---
(In reply to Martin Cermak from comment #9)
> Created attachment 8459 [details]
> proposed patch
>
> Attached patch seems to work for me. It doesn't contain test coverage and
> documentation yet. Does it look good so far?
I see one code omission - the changes to session.cxx don't look complete. You
updated the regular constructor, but not the copy constructor for the
systemtap_session class.
In general it seems odd to have both session->prologue_searching and
session->prologue_searching_mode. I'd think you'd get rid of
session->prologue_searching and make "-P" a synonym for
"--prologue-searching=always". Also, you'll have to be careful with
ENABLE_PROLOGUES.
--
You are receiving this mail because:
You are the assignee for the bug.
next prev parent reply other threads:[~2015-08-14 19:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-09 9:29 [Bug tapsets/18649] New: " mcermak at redhat dot com
2015-07-09 9:32 ` [Bug tapsets/18649] " mcermak at redhat dot com
2015-07-09 15:50 ` jistone at redhat dot com
2015-07-10 20:45 ` mcermak at redhat dot com
2015-07-10 20:57 ` mcermak at redhat dot com
2015-07-10 21:47 ` jistone at redhat dot com
2015-07-13 14:38 ` dsmith at redhat dot com
2015-07-13 16:52 ` jistone at redhat dot com
2015-07-21 14:10 ` mcermak at redhat dot com
2015-07-29 16:29 ` mcermak at redhat dot com
2015-08-14 19:07 ` dsmith at redhat dot com [this message]
2015-08-21 7:49 ` mcermak at redhat dot com
2015-08-21 13:50 ` dsmith at redhat dot com
2015-08-21 17:42 ` jistone at redhat dot com
2015-08-31 8:22 ` mcermak at redhat dot com
2015-09-01 7:36 ` mcermak at redhat dot com
2015-09-04 7:47 ` mcermak at redhat dot com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-18649-6586-X4rfxORZnT@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=systemtap@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).