From: "dsmith at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sourceware.org
Subject: [Bug tapsets/18650] powerpc variant of longlong_arg() for uprobes swaps the high and low half of its 64bit retval
Date: Thu, 09 Jul 2015 15:59:00 -0000 [thread overview]
Message-ID: <bug-18650-6586-DQkF74xffG@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-18650-6586@http.sourceware.org/bugzilla/>
https://sourceware.org/bugzilla/show_bug.cgi?id=18650
David Smith <dsmith at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dsmith at redhat dot com
--- Comment #1 from David Smith <dsmith at redhat dot com> ---
The powerpc change seems correct, as can be seen in the following function
prototypes:
asmlinkage int compat_sys_ftruncate64(unsigned int fd, u32 reg4,
unsigned long high, unsigned long low)
asmlinkage int compat_sys_truncate64(const char __user * path, u32 reg4,
unsigned long high, unsigned long low)
I'd say your patch looks correct.
Up to this fairly recently 'powerpc' has always meant big-endian powerpc. With
the introduction of little-endian powerpc linux support, things have changed.
Have you tried this code work on a ppc64le system?
--
You are receiving this mail because:
You are the assignee for the bug.
next prev parent reply other threads:[~2015-07-09 15:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-09 9:39 [Bug tapsets/18650] New: powerpc variant of longlong_arg() for uprobes swaps the byte order mcermak at redhat dot com
2015-07-09 11:38 ` [Bug tapsets/18650] powerpc variant of longlong_arg() for uprobes swaps the high and low half of its 64bit retval mcermak at redhat dot com
2015-07-09 15:59 ` dsmith at redhat dot com [this message]
2015-07-10 14:11 ` mcermak at redhat dot com
2015-07-14 6:14 ` mcermak at redhat dot com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-18650-6586-DQkF74xffG@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=systemtap@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).