From: "dsmith at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sourceware.org
Subject: [Bug tapsets/18856] New: nfsd.close probe alias fails on rawhide
Date: Thu, 20 Aug 2015 15:00:00 -0000 [thread overview]
Message-ID: <bug-18856-6586@http.sourceware.org/bugzilla/> (raw)
https://sourceware.org/bugzilla/show_bug.cgi?id=18856
Bug ID: 18856
Summary: nfsd.close probe alias fails on rawhide
Product: systemtap
Version: unspecified
Status: NEW
Severity: normal
Priority: P2
Component: tapsets
Assignee: systemtap at sourceware dot org
Reporter: dsmith at redhat dot com
Target Milestone: ---
On rawhide (4.2.0-0.rc6.git1.1.fc24.x86_64), the nfsd.close probe alias no
longer resolves:
====
# stap -p4 -e 'probe nfsd.close {}'
semantic error: while resolving probe point: identifier 'nfsd' at <input>:1:7
source: probe nfsd.close {}
^
semantic error: no match
Pass 2: analysis failed. [man error::pass2]
====
This is because of the following kernel commit:
====
commit fd891454609ec036dc23e34536e45d655b4ca4db
Author: Christoph Hellwig <hch@lst.de>
Date: Tue Apr 28 15:41:16 2015 +0200
nfsd: remove nfsd_close
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
====
Here's a link to the actual patch:
<https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/fs/nfsd/vfs.c?id=fd891454609ec036dc23e34536e45d655b4ca4db>
As you can see in that patch, the nfsd_close() function was replace with a call
to fput(). We can't just move the nfsd.close probe to probe fput(), since
fput() is called all over the kernel.
So, basically this function we were probing is gone. The only solution I see at
this point is to make the nfsd.close probe point optional.
--
You are receiving this mail because:
You are the assignee for the bug.
next reply other threads:[~2015-08-20 15:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-20 15:00 dsmith at redhat dot com [this message]
2015-08-20 15:02 ` [Bug tapsets/18856] " dsmith at redhat dot com
2015-08-20 16:29 ` dsmith at redhat dot com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-18856-6586@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=systemtap@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).