From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <systemtap-return-23728-listarch-systemtap=sources.redhat.com@sourceware.org>
Received: (qmail 83558 invoked by alias); 20 Aug 2015 15:00:14 -0000
Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <systemtap.sourceware.org>
List-Subscribe: <mailto:systemtap-subscribe@sourceware.org>
List-Post: <mailto:systemtap@sourceware.org>
List-Help: <mailto:systemtap-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: systemtap-owner@sourceware.org
Received: (qmail 80497 invoked by uid 48); 20 Aug 2015 15:00:09 -0000
From: "dsmith at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sourceware.org
Subject: [Bug tapsets/18856] New: nfsd.close probe alias fails on rawhide
Date: Thu, 20 Aug 2015 15:00:00 -0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: systemtap
X-Bugzilla-Component: tapsets
X-Bugzilla-Version: unspecified
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: dsmith at redhat dot com
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: systemtap at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter target_milestone
Message-ID: <bug-18856-6586@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-q3/txt/msg00091.txt.bz2

https://sourceware.org/bugzilla/show_bug.cgi?id=18856

            Bug ID: 18856
           Summary: nfsd.close probe alias fails on rawhide
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: tapsets
          Assignee: systemtap at sourceware dot org
          Reporter: dsmith at redhat dot com
  Target Milestone: ---

On rawhide (4.2.0-0.rc6.git1.1.fc24.x86_64), the nfsd.close probe alias no
longer resolves:

====
# stap -p4 -e 'probe nfsd.close {}'
semantic error: while resolving probe point: identifier 'nfsd' at <input>:1:7
        source: probe nfsd.close {}
                      ^

semantic error: no match

Pass 2: analysis failed.  [man error::pass2]
====

This is because of the following kernel commit:

====
commit fd891454609ec036dc23e34536e45d655b4ca4db
Author: Christoph Hellwig <hch@lst.de>
Date:   Tue Apr 28 15:41:16 2015 +0200

    nfsd: remove nfsd_close

    Signed-off-by: Christoph Hellwig <hch@lst.de>
    Signed-off-by: J. Bruce Fields <bfields@redhat.com>
====

Here's a link to the actual patch:

<https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/fs/nfsd/vfs.c?id=fd891454609ec036dc23e34536e45d655b4ca4db>

As you can see in that patch, the nfsd_close() function was replace with a call
to fput(). We can't just move the nfsd.close probe to probe fput(), since
fput() is called all over the kernel.

So, basically this function we were probing is gone. The only solution I see at
this point is to make the nfsd.close probe point optional.

-- 
You are receiving this mail because:
You are the assignee for the bug.