[Bug translator/19120] New: kbuild warnings on RHEL5

[Bug translator/19120] New: kbuild warnings on RHEL5

[dsmith at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=19120

            Bug ID: 19120
           Summary: kbuild warnings on RHEL5
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: translator
          Assignee: systemtap at sourceware dot org
          Reporter: dsmith at redhat dot com
  Target Milestone: ---

I'm seeing kbuild warnings on RHEL5 (ia64 in this case, but I believe I've seen
them on other arches):

====
# stap ../../src/testsuite/systemtap.base/task_paths.stp -c whoami
WARNING: kbuild exited with status: 2
WARNING: kbuild exited with status: 2
====

This doesn't appear to be harmful, just noisy.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug translator/19120] kbuild warnings on RHEL5

[mcermak at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=19120

Martin Cermak <mcermak at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mcermak at redhat dot com

--- Comment #1 from Martin Cermak <mcermak at redhat dot com> ---
Looks like it's because fullpath_struct_path() refers to linux/path.h which
doesn't seem to exist in rhel5 kernel.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug translator/19120] kbuild warnings on RHEL5

[mcermak at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=19120

--- Comment #2 from Martin Cermak <mcermak at redhat dot com> ---
Those warnings come from fullpath_struct_path(). A smaller reproducer is:

=======
stap -e 'probe oneshot { println
(fullpath_struct_path(task_cwd_path(task_current())))  } '
=======

Which passes on rhel6+ and fail on my rhel5 running 2.6.18-398.el5. However,
task_cwd_path() is *supposed* to return null:

=======
function task_cwd_path:long(task:long)
%{ /* pure */
... stuff deleted ...
        if (task->fs) {
                // Sigh. On kernels before 2.6.25, the task->fs->pwd
                // structure exists, but isn't a 'path'
                // structure. Instead it is a 'dentry' structure. The 
                // 'pwd' and 'pwdmnt' (which is a 'vfsmount'
                // structure) variables would both be needed to get a
                // pathname. However, this function can't return 2
                // items or really declare a static 'path' structure
                // to put the 2 pointers in. 
                //
                // So, on those RHEL5-era kernels, we'll just return
                // NULL here.
... stuff deleted ...
=======

The fullpath_struct_path() might pick one of linux/path.h or linux/nfs_fs.h
using @choose_defined() for the cast. Nevertheless that would neither suppress
those warnings, nor make task_paths.stp pass since task_cwd_path() will still
return null on such old kernel.

So maybe the best way would be to use autoconf-dpath-path.c which sets
STAPCONF_DPATH_PATH and let it drive the behavior of fullpath_struct_path()
making it return null on such old kernels.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug translator/19120] kbuild warnings on RHEL5

[dsmith at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=19120

David Smith <dsmith at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from David Smith <dsmith at redhat dot com> ---
Fixed in commit 244ab90 by rearranging the list of modules to search in @cast()
in the tapset function fullpath_struct_path(). The kbuild warnings are no
longer present.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug translator/19120] kbuild warnings on RHEL5

[dsmith at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=19120

--- Comment #4 from David Smith <dsmith at redhat dot com> ---
I added one more tweak in commit aaf9877 to fix a problem that Josh Stone
pointed out (that we were treating <linux/path.h> as a userspace header, not a
kernel header).

-- 
You are receiving this mail because:
You are the assignee for the bug.