From: "dsmith at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sourceware.org
Subject: [Bug translator/19358] netfilter probes are broken on rawhide
Date: Fri, 11 Dec 2015 17:46:00 -0000 [thread overview]
Message-ID: <bug-19358-6586-OK5IRD2eu2@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-19358-6586@http.sourceware.org/bugzilla/>
https://sourceware.org/bugzilla/show_bug.cgi?id=19358
--- Comment #1 from David Smith <dsmith at redhat dot com> ---
It looks like the following kernel commit got rid of the 'owner' field:
====
ommit 2ffbceb2b08f8ca0496c54a9ebcd11d25275954e
Author: Florian Westphal <fw@strlen.de>
Date: Tue Oct 13 14:33:26 2015 +0200
netfilter: remove hook owner refcounting
since commit 8405a8fff3f8 ("netfilter: nf_qeueue: Drop queue entries on
nf_unregister_hook") all pending queued entries are discarded.
So we can simply remove all of the owner handling -- when module is
removed it also needs to unregister all its hooks.
====
It looks like the following kernel commit changed the 'hook' field:
====
commit 008027c31d57a22bd80dda5acc95b037634eee0f
Author: Arnd Bergmann <arnd@arndb.de>
Date: Fri Oct 9 20:45:42 2015 +0200
netfilter: turn NF_HOOK into an inline function
A recent change to the dst_output handling caused a new warning
when the call to NF_HOOK() is the only used of a local variable
passed as 'dev', and CONFIG_NETFILTER is disabled:
net/ipv6/ip6_output.c: In function 'ip6_output':
net/ipv6/ip6_output.c:135:21: warning: unused variable 'dev'
[-Wunused-vari\
able]
The reason for this is that the NF_HOOK macro in this case does
not reference the variable at all, and the call to dev_net(dev)
got removed from the ip6_output function. To avoid that warning now
and in the future, this changes the macro into an equivalent
inline function, which tells the compiler that the variable is
passed correctly but still unused.
The dn_forward function apparently had the same problem in
the past and added a local workaround that no longer works
with the inline function. In order to avoid a regression, we
have to also remove the #ifdef from decnet in the same patch.
====
It looks like these changes first appeared in kernel v4.4-rc1.
--
You are receiving this mail because:
You are the assignee for the bug.
next prev parent reply other threads:[~2015-12-11 17:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-11 17:20 [Bug translator/19358] New: " dsmith at redhat dot com
2015-12-11 17:46 ` dsmith at redhat dot com [this message]
2015-12-11 19:40 ` [Bug translator/19358] " dsmith at redhat dot com
2015-12-11 20:46 ` dsmith at redhat dot com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-19358-6586-OK5IRD2eu2@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=systemtap@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).