From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <systemtap-return-24067-listarch-systemtap=sources.redhat.com@sourceware.org>
Received: (qmail 94195 invoked by alias); 11 Dec 2015 17:46:32 -0000
Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <systemtap.sourceware.org>
List-Subscribe: <mailto:systemtap-subscribe@sourceware.org>
List-Post: <mailto:systemtap@sourceware.org>
List-Help: <mailto:systemtap-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: systemtap-owner@sourceware.org
Received: (qmail 93913 invoked by uid 48); 11 Dec 2015 17:46:27 -0000
From: "dsmith at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sourceware.org
Subject: [Bug translator/19358] netfilter probes are broken on rawhide
Date: Fri, 11 Dec 2015 17:46:00 -0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: systemtap
X-Bugzilla-Component: translator
X-Bugzilla-Version: unspecified
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: dsmith at redhat dot com
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: systemtap at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-19358-6586-OK5IRD2eu2@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-19358-6586@http.sourceware.org/bugzilla/>
References: <bug-19358-6586@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-q4/txt/msg00271.txt.bz2

https://sourceware.org/bugzilla/show_bug.cgi?id=3D19358

--- Comment #1 from David Smith <dsmith at redhat dot com> ---
It looks like the following kernel commit got rid of the 'owner' field:

=3D=3D=3D=3D
ommit 2ffbceb2b08f8ca0496c54a9ebcd11d25275954e=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20
Author: Florian Westphal <fw@strlen.de>=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20
Date:   Tue Oct 13 14:33:26 2015 +0200=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20

    netfilter: remove hook owner refcounting=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20

    since commit 8405a8fff3f8 ("netfilter: nf_qeueue: Drop queue entries on=
=20=20=20=20=20
    nf_unregister_hook") all pending queued entries are discarded.=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20

    So we can simply remove all of the owner handling -- when module is=20=
=20=20=20=20=20=20=20=20
    removed it also needs to unregister all its hooks.=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20
=3D=3D=3D=3D

It looks like the following kernel commit changed the 'hook' field:

=3D=3D=3D=3D
commit 008027c31d57a22bd80dda5acc95b037634eee0f=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20
Author: Arnd Bergmann <arnd@arndb.de>=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20
Date:   Fri Oct 9 20:45:42 2015 +0200=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20

    netfilter: turn NF_HOOK into an inline function=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20

    A recent change to the dst_output handling caused a new warning=20=20=
=20=20=20=20=20=20=20=20=20=20=20
    when the call to NF_HOOK() is the only used of a local variable=20=20=
=20=20=20=20=20=20=20=20=20=20=20
    passed as 'dev', and CONFIG_NETFILTER is disabled:=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20

    net/ipv6/ip6_output.c: In function 'ip6_output':=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20
    net/ipv6/ip6_output.c:135:21: warning: unused variable 'dev'
[-Wunused-vari\
able]=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20

    The reason for this is that the NF_HOOK macro in this case does=20=20=
=20=20=20=20=20=20=20=20=20=20=20
    not reference the variable at all, and the call to dev_net(dev)=20=20=
=20=20=20=20=20=20=20=20=20=20=20
    got removed from the ip6_output function. To avoid that warning now=20=
=20=20=20=20=20=20=20=20
    and in the future, this changes the macro into an equivalent=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20
    inline function, which tells the compiler that the variable is=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20
    passed correctly but still unused.=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20

    The dn_forward function apparently had the same problem in=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20
    the past and added a local workaround that no longer works=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20
    with the inline function. In order to avoid a regression, we=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20
    have to also remove the #ifdef from decnet in the same patch.=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20
=3D=3D=3D=3D

It looks like these changes first appeared in kernel v4.4-rc1.

--=20
You are receiving this mail because:
You are the assignee for the bug.