From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 98EA2386D606; Thu, 15 Feb 2024 20:12:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 98EA2386D606 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1708027968; bh=HiFOuy5JrxzOPEB3puSxbaI/bSWu5C9StHgfbirGGLc=; h=From:To:Subject:Date:In-Reply-To:References:From; b=BG5zhHf+Vue/JS76jKhp9zJ3oLyWfX2hNrIG/CTPXZ7+vR1AEdolyElmfKAn1Ttm+ LBRMrs5tbZmb3J6gPjBCmJymIlROEPVmA6FbSFb70MAdl6/NU8Z7DCYBTvHksoxkeh tcRfoxjPQ4FQJLSqGQwTkEf7MI4dI676okBCkxhE= From: "wcohen at redhat dot com" To: systemtap@sourceware.org Subject: [Bug runtime/19360] Verify that examples and tapsets with return probes use @entry for function arguments Date: Thu, 15 Feb 2024 20:12:47 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: systemtap X-Bugzilla-Component: runtime X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: wcohen at redhat dot com X-Bugzilla-Status: RESOLVED X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: systemtap at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_status resolution Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://sourceware.org/bugzilla/show_bug.cgi?id=3D19360 William Cohen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from William Cohen --- Reviewed the examples in testsuite/systmetap.examples. Found a couple corrections needed to be made in fslatency-nd.stp and fsslower-nd.stp. commit 01261944787df5c757d55fe2ec081b70a1723ab0 (HEAD -> master, origin/mas= ter, origin/HEAD) Author: William Cohen Date: Thu Feb 15 15:01:53 2024 -0500 PR19360: Correct lwtools fslatency-nd.stp and fsslower-nd.stp Reviewed examples to ensure that the entry value for a function argument is used for function return probes. Found that __vfs_write.return probes aliases were missing ".return" and needed an @entry() for the argument fetch in fslatency-nd.stp and fsslower-nd.stp. --=20 You are receiving this mail because: You are the assignee for the bug.=