From: "wcohen at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sourceware.org
Subject: [Bug runtime/19360] New: Verify that examples and tapsets with return probes use @entry for function arguments
Date: Fri, 11 Dec 2015 22:34:00 -0000 [thread overview]
Message-ID: <bug-19360-6586@http.sourceware.org/bugzilla/> (raw)
https://sourceware.org/bugzilla/show_bug.cgi?id=19360
Bug ID: 19360
Summary: Verify that examples and tapsets with return probes
use @entry for function arguments
Product: systemtap
Version: unspecified
Status: NEW
Severity: normal
Priority: P2
Component: runtime
Assignee: systemtap at sourceware dot org
Reporter: wcohen at redhat dot com
Target Milestone: ---
When reviewing test results on aarch64 I found that the systemtap lwtools
examples fslatency-nd.stp and fsslower-nd.stp were not using correct values of
arguments for return probe. This is because the aarch64 arguments are stored
in registers that can be overwritten in the function. These uses should be
wrapped by @entry to make sure the value from the function entry is used. It
would be very wise to review the other scripts and tapsets in systemtap to
ensure that this problem is not lurking elsewhere. For problem entries do
something like what is done in:
https://sourceware.org/git/gitweb.cgi?p=systemtap.git;a=commit;h=3d0c2f452f09a64b800aabe68508f8f0183f0ea1
--
You are receiving this mail because:
You are the assignee for the bug.
next reply other threads:[~2015-12-11 22:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-11 22:34 wcohen at redhat dot com [this message]
2024-02-15 20:12 ` [Bug runtime/19360] " wcohen at redhat dot com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-19360-6586@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=systemtap@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).