From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <systemtap-return-24157-listarch-systemtap=sources.redhat.com@sourceware.org>
Received: (qmail 23125 invoked by alias); 22 Jan 2016 17:04:56 -0000
Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <systemtap.sourceware.org>
List-Subscribe: <mailto:systemtap-subscribe@sourceware.org>
List-Post: <mailto:systemtap@sourceware.org>
List-Help: <mailto:systemtap-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: systemtap-owner@sourceware.org
Received: (qmail 22917 invoked by uid 48); 22 Jan 2016 17:04:51 -0000
From: "dsmith at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sourceware.org
Subject: [Bug translator/19510] the "private" keyword support has made -p1 output less useful
Date: Fri, 22 Jan 2016 17:04:00 -0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: systemtap
X-Bugzilla-Component: translator
X-Bugzilla-Version: unspecified
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: dsmith at redhat dot com
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: systemtap at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-19510-6586-a7bGSmIJZH@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-19510-6586@http.sourceware.org/bugzilla/>
References: <bug-19510-6586@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2016-q1/txt/msg00053.txt.bz2

https://sourceware.org/bugzilla/show_bug.cgi?id=3D19510

--- Comment #2 from David Smith <dsmith at redhat dot com> ---
The 2 failues in the testcase are:

=3D=3D=3D=3D
Running ../../src/testsuite/systemtap.pass1-4/parse-semok.exp ...
FAIL: buildok/delete.stp parse-semok - parsed output is not semok
FAIL: buildok/one.stp parse-semok - parsed output is not semok
=3D=3D=3D=3D

1) delete.stp: Here's the smallest delete problem:

=3D=3D=3D=3D
# cat minidelete.stp=20
global a, b
probe begin {
        a =3D 1
        delete a
        b =3D "b"
        delete b
}
#
# stap -p2 minidelete.stp
# globals
a:long
b:string
# probes
begin /* <- begin */
#
# stap -p1 minidelete.stp > minidelete.p1
# cat minidelete.p1
# parse tree dump
# file minidelete.stp
global a
global b
probe begin{
(a) =3D (1)
delete a
(b) =3D ("b")
delete b
}

# stap -p2 minidelete.p1
semantic error: unresolved function (similar: __global_HZ, __global_pn,
__global_pp, __global_cpu, __global_gid): identifier 'a' at minidelete.p1:7=
:8
        source: delete a
                       ^

Pass 2: analysis failed.  [man error::pass2]
=3D=3D=3D=3D

So, for some reason the addition of parenthesis around 'a' causes stap to n=
ot
be able to find 'a'. I'm not sure that it matters, but in the error message
stap seems to think that 'a' is a function, not a global variable.

2) one.stp: Here's the smallest 'one' problem described:

=3D=3D=3D=3D
# cat minione.stp
#! stap -p4

global foo
probe begin
{
        foo["hello"] =3D 25
        foo["hello"]++
        foo["hello"] =3D 0;
        ++foo["hello"]
}
# stap -p2 minione.stp
# globals
foo:long [string]
# probes
begin /* <- begin */
end /* <- end */
  # locals
  :string
  :long
# stap -p1 minione.stp > minione.p1
# cat minione.p1
# parse tree dump
# file minione.stp
global foo
probe begin{
(foo["hello"]) =3D (25)
(foo["hello"])++
(foo["hello"]) =3D (0)
++(foo["hello"])
}
# stap -p2 minione.p1
WARNING: Eliding side-effect-free expression : operator '(' at minione.p1:8=
:3
 source: ++(foo["hello"])
           ^
# globals
foo:long [string]
# probes
begin /* <- begin */
end /* <- end */
  # locals
  :string
  :long
=3D=3D=3D=3D

So, somehow the addition of parentheses aournd '++(foo["hello")' causes the
warning.

--=20
You are receiving this mail because:
You are the assignee for the bug.