From: "dsmith at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sourceware.org
Subject: [Bug translator/19510] the "private" keyword support has made -p1 output less useful
Date: Fri, 22 Jan 2016 20:21:00 -0000 [thread overview]
Message-ID: <bug-19510-6586-tjKF5zoaDP@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-19510-6586@http.sourceware.org/bugzilla/>
https://sourceware.org/bugzilla/show_bug.cgi?id=19510
David Smith <dsmith at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #4 from David Smith <dsmith at redhat dot com> ---
(In reply to Josh Stone from comment #3)
> Both of these are due to not using semicolons. Whitespace is not
> significant, including newlines, so write it on one line to get an idea what
> the parser sees.
>
> > delete a b = "b"
> > delete a (b) = ("b")
>
> The latter looks like it's calling a(b).
>
> > foo["hello"] = 0 ; ++ foo["hello"]
> > (foo["hello"]) = (0) ++ (foo["hello"])
>
> Note the former required a semicolon to parse as desired!
> The latter is parsed like (0)++, then side-effect-free foo["hello"].
>
>
> We probably should output semicolons after all statements to disambiguate
> things, similar to how we wrap all expressions in parentheses.
Yep, it looks like that was the problem.
I solved this by cherry-picking commit 3070a37 from the dsmith/interactive
branch (where I had already fixed this problem). This commit adds a semi-colon
to the end of statements in '-p1' mode. On the master branch, this is commit
d89c429. I also added commit 62ac4ea, which fixes a few places missed by commit
9fef07f when adding the unmangled name global variable output support.
The new parse-semok.exp test now passes completely on f23
(4.3.3-300.fc23.x86_64).
--
You are receiving this mail because:
You are the assignee for the bug.
prev parent reply other threads:[~2016-01-22 20:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-21 19:52 [Bug translator/19510] New: " dsmith at redhat dot com
2016-01-21 19:58 ` [Bug translator/19510] " dsmith at redhat dot com
2016-01-22 17:04 ` dsmith at redhat dot com
2016-01-22 19:21 ` jistone at redhat dot com
2016-01-22 20:21 ` dsmith at redhat dot com [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-19510-6586-tjKF5zoaDP@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=systemtap@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).