[Bug translator/19521] New: the "private" keyword support has made error messages less useful

[Bug translator/19521] New: the "private" keyword support has made error messages less useful

[dsmith at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=19521

            Bug ID: 19521
           Summary: the "private" keyword support has made error messages
                    less useful
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: translator
          Assignee: systemtap at sourceware dot org
          Reporter: dsmith at redhat dot com
  Target Milestone: ---

====
# stap -ve 'probe begin { log(egid2()) }'
Pass 1: parsed user script and 112 library script(s) using
237668virt/36508res/7440shr/29392data kb, in 170usr/60sys/501real ms.
semantic error: unresolved function (similar: __global_egid, __global_gid,
__global_euid, __global_ns_egid, __global_pid): identifier 'egid2' at
<input>:1:19
        source: probe begin { log(egid2()) }
                                  ^

Pass 2: analyzed script: 1 probe(s), 0 function(s), 0 embed(s), 0 global(s)
using 238468virt/37544res/7704shr/30184data kb, in 10usr/0sys/21real ms.
Pass 2: analysis failed.  [man error::pass2]
====

The '__global_' function prefixes in the error message could confuse the user,
since there really aren't functions named that.

Similar things happen with global variables:

====
stap -p4 -ve 'global a; probe begin { log(a2) }'
Pass 1: parsed user script and 112 library script(s) using
235400virt/36236res/7192shr/29216data kb, in 190usr/40sys/499real ms.
WARNING: never-assigned local variable 'a2' (similar: __global_a): identifier
'a2' at <input>:1:29
 source: global a; probe begin { log(a2) }
                                     ^
WARNING: Eliding unused variable '__global_a': identifier 'a' at :1:8
 source: global a; probe begin { log(a2) }
                ^
Pass 2: analyzed script: 1 probe(s), 1 function(s), 0 embed(s), 0 global(s)
using 236068virt/37272res/7456shr/29876data kb, in 10usr/10sys/17real ms.
Pass 3: translated to C into
"/tmp/stapmh9bg1/stap_8d9e94e640832bf80edacd29b05a3cc3_1074_src.c" using
236068virt/37272res/7456shr/29876data kb, in 0usr/0sys/0real ms.
/home/dsmith/.systemtap/cache/8d/stap_8d9e94e640832bf80edacd29b05a3cc3_1074.ko
Pass 4: compiled C into "stap_8d9e94e640832bf80edacd29b05a3cc3_1074.ko" in
15070usr/8090sys/50641real ms.
====

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug translator/19521] the "private" keyword support has made error messages less useful

[dsmith at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=19521

David Smith <dsmith at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from David Smith <dsmith at redhat dot com> ---
Fixed in commit 5eb6ecb. There are probably a few messages still lurking that
print the "mangled" name, but this commit hopefully got the majority.

-- 
You are receiving this mail because:
You are the assignee for the bug.