[Bug translator/19700] New: Support dash as /bin/sh in generated Makefile

[Bug translator/19700] New: Support dash as /bin/sh in generated Makefile

[orivej at gmx dot fr]

https://sourceware.org/bugzilla/show_bug.cgi?id=19700

            Bug ID: 19700
           Summary: Support dash as /bin/sh in generated Makefile
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: translator
          Assignee: systemtap at sourceware dot org
          Reporter: orivej at gmx dot fr
  Target Milestone: ---

Created attachment 9024
  --> https://sourceware.org/bugzilla/attachment.cgi?id=9024&action=edit
Replace "echo -n" with "touch"

buildrun-generated makefile runs "echo -n > stapconf_….h", and under dash as
/bin/sh this results in literal "-n" at the begging of the generated header
file.  The attached patch suggests to replace "echo -n" with "touch".

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug translator/19700] Support dash as /bin/sh in generated Makefile

[fche at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=19700

Frank Ch. Eigler <fche at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |WAITING
                 CC|                            |fche at redhat dot com

--- Comment #1 from Frank Ch. Eigler <fche at redhat dot com> ---
That looks OK, but there are many other 'echo -n's within the package.  Does
dash have some standardish way to echo without a \n ?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug translator/19700] Support dash as /bin/sh in generated Makefile

[orivej at gmx dot fr]

https://sourceware.org/bugzilla/show_bug.cgi?id=19700

Orivej Desh <orivej at gmx dot fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |NEW

--- Comment #2 from Orivej Desh <orivej at gmx dot fr> ---
It turned out that it is not the stock dash, but a Gentoo-patched one that
disables usual behaviour of echo -n:
https://gitweb.gentoo.org/repo/gentoo.git/tree/app-shells/dash/files/dash-0.5.8.1-dumb-echo.patch

Anyway, except for "buildrun.cxx", systemtap uses "echo -n" either in scripts
with "#!/bin/bash" or in "configure" scripts (legitimately, to test echo
behaviour), so the only case where it presents a problem for Gentoo-patched
dash is in "buildrun.cxx".

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug translator/19700] Support dash as /bin/sh in generated Makefile

[orivej at gmx dot fr]

https://sourceware.org/bugzilla/show_bug.cgi?id=19700

--- Comment #3 from Orivej Desh <orivej at gmx dot fr> ---
You can also just put "SHELL = /bin/bash" in the generated Makefile and not
care about shell compatibility.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug translator/19700] Support dash as /bin/sh in generated Makefile

[orivej at gmx dot fr]

https://sourceware.org/bugzilla/show_bug.cgi?id=19700

--- Comment #5 from Orivej Desh <orivej at gmx dot fr> ---
Created attachment 9026
  --> https://sourceware.org/bugzilla/attachment.cgi?id=9026&action=edit
echo.patch

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug translator/19700] Support dash as /bin/sh in generated Makefile

[orivej at gmx dot fr]

https://sourceware.org/bugzilla/show_bug.cgi?id=19700

Orivej Desh <orivej at gmx dot fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #9024|0                           |1
        is obsolete|                            |

--- Comment #4 from Orivej Desh <orivej at gmx dot fr> ---
Created attachment 9025
  --> https://sourceware.org/bugzilla/attachment.cgi?id=9025&action=edit
shell.patch

I thought that maybe "echo -n >" is there for reruns that need to truncate the
generated file.  Any of the two following patches preserve this property.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug translator/19700] Support dash as /bin/sh in generated Makefile

[fche at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=19700

Frank Ch. Eigler <fche at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Frank Ch. Eigler <fche at redhat dot com> ---
committed the last version of the patch, thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.