* [Bug translator/20599] New: collected bit shift & variance rewritten by new histogram during elaboration @ 2016-09-12 12:25 mcermak at redhat dot com 2016-09-13 9:54 ` [Bug translator/20599] " mcermak at redhat dot com ` (3 more replies) 0 siblings, 4 replies; 5+ messages in thread From: mcermak at redhat dot com @ 2016-09-12 12:25 UTC (permalink / raw) To: systemtap https://sourceware.org/bugzilla/show_bug.cgi?id=20599 Bug ID: 20599 Summary: collected bit shift & variance rewritten by new histogram during elaboration Product: systemtap Version: unspecified Status: NEW Severity: normal Priority: P2 Component: translator Assignee: systemtap at sourceware dot org Reporter: mcermak at redhat dot com Target Milestone: --- Created attachment 9508 --> https://sourceware.org/bugzilla/attachment.cgi?id=9508&action=edit proposed patch Following script fails to compute variance correctly: ======= $ stap --poison-cache -e 'global x probe oneshot { x<<<1 x<<<10 x<<<100 println("v: ", @variance(x, 3)) print(@hist_linear(x, 0, 100, 1)) }' v: 1944 value |-------------------------------------------------- count 0 | 0 1 |@ 1 2 | 0 3 | 0 ~ 8 | 0 9 | 0 10 |@ 1 11 | 0 12 | 0 ~ 98 | 0 99 | 0 100 |@ 1 $ ======= In the above example, variance should have been 2997, not 1944: ======= $ stap --poison-cache -e 'global x probe oneshot { x<<<1 x<<<10 x<<<100 println("v: ", @variance(x, 3)) }' v: 2997 $ ======= One can check the `... -p3 | grep _stp_stat_init` output to see that in the first case, new histogram rewrites collected stat_ops and bit_shift for given global. This problem comes from the elaboration phase. Attached patch fixes it. -- You are receiving this mail because: You are the assignee for the bug. ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug translator/20599] collected bit shift & variance rewritten by new histogram during elaboration 2016-09-12 12:25 [Bug translator/20599] New: collected bit shift & variance rewritten by new histogram during elaboration mcermak at redhat dot com @ 2016-09-13 9:54 ` mcermak at redhat dot com 2016-09-13 11:39 ` mcermak at redhat dot com ` (2 subsequent siblings) 3 siblings, 0 replies; 5+ messages in thread From: mcermak at redhat dot com @ 2016-09-13 9:54 UTC (permalink / raw) To: systemtap https://sourceware.org/bugzilla/show_bug.cgi?id=20599 Martin Cermak <mcermak at redhat dot com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Martin Cermak <mcermak at redhat dot com> --- Fixed in commit 4d0a1c2359e069c37fc9cccb1824ad22620afa9f -- You are receiving this mail because: You are the assignee for the bug. ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug translator/20599] collected bit shift & variance rewritten by new histogram during elaboration 2016-09-12 12:25 [Bug translator/20599] New: collected bit shift & variance rewritten by new histogram during elaboration mcermak at redhat dot com 2016-09-13 9:54 ` [Bug translator/20599] " mcermak at redhat dot com @ 2016-09-13 11:39 ` mcermak at redhat dot com 2016-09-13 11:41 ` [Bug translator/20599] histogram breaks @variance mcermak at redhat dot com 2016-09-14 11:15 ` mcermak at redhat dot com 3 siblings, 0 replies; 5+ messages in thread From: mcermak at redhat dot com @ 2016-09-13 11:39 UTC (permalink / raw) To: systemtap https://sourceware.org/bugzilla/show_bug.cgi?id=20599 --- Comment #2 from Martin Cermak <mcermak at redhat dot com> --- Created attachment 9509 --> https://sourceware.org/bugzilla/attachment.cgi?id=9509&action=edit related testcase updates -- You are receiving this mail because: You are the assignee for the bug. ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug translator/20599] histogram breaks @variance 2016-09-12 12:25 [Bug translator/20599] New: collected bit shift & variance rewritten by new histogram during elaboration mcermak at redhat dot com 2016-09-13 9:54 ` [Bug translator/20599] " mcermak at redhat dot com 2016-09-13 11:39 ` mcermak at redhat dot com @ 2016-09-13 11:41 ` mcermak at redhat dot com 2016-09-14 11:15 ` mcermak at redhat dot com 3 siblings, 0 replies; 5+ messages in thread From: mcermak at redhat dot com @ 2016-09-13 11:41 UTC (permalink / raw) To: systemtap https://sourceware.org/bugzilla/show_bug.cgi?id=20599 Martin Cermak <mcermak at redhat dot com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|collected bit shift & |histogram breaks @variance |variance rewritten by new | |histogram during | |elaboration | -- You are receiving this mail because: You are the assignee for the bug. ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug translator/20599] histogram breaks @variance 2016-09-12 12:25 [Bug translator/20599] New: collected bit shift & variance rewritten by new histogram during elaboration mcermak at redhat dot com ` (2 preceding siblings ...) 2016-09-13 11:41 ` [Bug translator/20599] histogram breaks @variance mcermak at redhat dot com @ 2016-09-14 11:15 ` mcermak at redhat dot com 3 siblings, 0 replies; 5+ messages in thread From: mcermak at redhat dot com @ 2016-09-14 11:15 UTC (permalink / raw) To: systemtap https://sourceware.org/bugzilla/show_bug.cgi?id=20599 --- Comment #3 from Martin Cermak <mcermak at redhat dot com> --- Pushed as commit 5c6d39236741312fb0999d0b79d8d33f31388663 . -- You are receiving this mail because: You are the assignee for the bug. ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-09-14 11:15 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2016-09-12 12:25 [Bug translator/20599] New: collected bit shift & variance rewritten by new histogram during elaboration mcermak at redhat dot com 2016-09-13 9:54 ` [Bug translator/20599] " mcermak at redhat dot com 2016-09-13 11:39 ` mcermak at redhat dot com 2016-09-13 11:41 ` [Bug translator/20599] histogram breaks @variance mcermak at redhat dot com 2016-09-14 11:15 ` mcermak at redhat dot com
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).