public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: "fche at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sourceware.org
Subject: [Bug runtime/21020] reorganize argument passing from java probes
Date: Tue, 10 Jan 2017 02:49:00 -0000	[thread overview]
Message-ID: <bug-21020-6586-fqaAh5lCfv@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-21020-6586@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=21020

--- Comment #3 from Frank Ch. Eigler <fche at redhat dot com> ---
> If I built correctly from git source, as of commit f8bc2a5eb3e91ce7
> "PR21020: reorganize data passing abi for java method parameters",
> it is no longer possible to access java.lang.String argument using
> --compatible=3.0 option because $arg1 in method2 points to NULL.
> Is this what you meant?

Yeah, this was a side-effect of code cleanup.  Passing strings under
the previous abi implied a memory leak (a strdup for every call that
was not freed, because every type was cast to an int64_t).  That leak
is fixed under --compatible=3.0 but at the cost of not having strings
be copied at all.  That is a regression, but it didn't seem like a
big one.  Do you think it is important to have it work under
--compatible=3.0?

-- 
You are receiving this mail because:
You are the assignee for the bug.

  parent reply	other threads:[~2017-01-10  2:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-03 14:38 [Bug runtime/21020] New: " fche at redhat dot com
2017-01-04  0:10 ` [Bug runtime/21020] " penguin-kernel@i-love.sakura.ne.jp
2017-01-06 22:44 ` fche at redhat dot com
2017-01-10  2:36 ` penguin-kernel@i-love.sakura.ne.jp
2017-01-10  2:49 ` fche at redhat dot com [this message]
2017-01-11  2:16 ` penguin-kernel@i-love.sakura.ne.jp
2017-01-11  2:41 ` fche at redhat dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-21020-6586-fqaAh5lCfv@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=systemtap@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).