[Bug runtime/21063] New: dtrace script causes mysterious build failures due to improper forming of gcc command line

[Bug runtime/21063] New: dtrace script causes mysterious build failures due to improper forming of gcc command line

[630dr7+9vgtozzjuj0gg at sharklasers dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=21063

            Bug ID: 21063
           Summary: dtrace script causes mysterious build failures due to
                    improper forming of gcc command line
           Product: systemtap
           Version: unspecified
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: runtime
          Assignee: systemtap at sourceware dot org
          Reporter: 630dr7+9vgtozzjuj0gg at sharklasers dot com
  Target Milestone: ---

From https://bugzilla.redhat.com/show_bug.cgi?id=1413762

When users provide a CFLAGS envar which containts newlines, the dtrace script
fails with:

gcc: error: 
   : No such file or directory

For example, the fedora rpm spec file for creating packages defines:

CFLAGS="-O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2
-fexceptions -fstack-protector-strong --param=ssp-buffer-size=4
-grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64
-mtune=generic -g \
               -D_LARGEFILE_SOURCE \
               -D_FILE_OFFSET_BITS=64 \
               -DZLIB_CONST \
               -fno-delete-null-pointer-checks"

and the multiple lines cause the dtrace script to die. Possibly, this error has
caused packagers to believe systemtap USDT's have not been available in project
where in fact it has been, because using "--with-dtrace" caused compilation
errors which were taken as due to general unavailability of the real dtrace
tool on linux.

The problem is towards the end of the `dtrace script`:

        cmd=split(cc1) + defines + includes + split(cflags) +\
             ["-fPIC", "-I.", "-I/usr/include", "-c", fname, "-o",
              filename + suffix]

where cflags should be sanitized so that examples like the above CFLAGS are
tolerated.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug runtime/21063] dtrace script causes mysterious build failures due to improper forming of gcc command line

[630dr7+9vgtozzjuj0gg at sharklasers dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=21063

Kinston Hughes <630dr7+9vgtozzjuj0gg at sharklasers dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugzilla.redhat.com
                   |                            |/show_bug.cgi?id=1413762

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug runtime/21063] dtrace script causes mysterious build failures due to improper forming of gcc command line

[fche at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=21063

Frank Ch. Eigler <fche at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fche at redhat dot com

--- Comment #1 from Frank Ch. Eigler <fche at redhat dot com> ---
I'm having trouble reproducing this with a plain set of commands lines.  Do you
have a copy&paste'able recipe to trigger the behaviour?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug runtime/21063] dtrace script causes mysterious build failures due to improper forming of gcc command line

[630dr7+9vgtozzjuj0gg at sharklasers dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=21063

--- Comment #2 from Kinston Hughes <630dr7+9vgtozzjuj0gg at sharklasers dot com> ---
(In reply to Frank Ch. Eigler from comment #1)
> I'm having trouble reproducing this with a plain set of commands lines.  Do
> you have a copy&paste'able recipe to trigger the behaviour?

Sorry, this should do it.

```
#!/bin/sh

wget https://raw.githubusercontent.com/nodejs/node/master/src/node_provider.d

export CFLAGS='-g \
               -fno-delete-null-pointer-checks'
dtrace -G -s node_provider.d -o node_provider.h
```

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug runtime/21063] dtrace script causes mysterious build failures due to improper forming of gcc command line

[fche at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=21063

Frank Ch. Eigler <fche at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Frank Ch. Eigler <fche at redhat dot com> ---
commit 100bca3f124 should fix this.  The problem here seems to be the \
character in the string rather than new lines, but the patch nukes them both.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug runtime/21063] dtrace script causes mysterious build failures due to improper forming of gcc command line

[630dr7+9vgtozzjuj0gg at sharklasers dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=21063

--- Comment #4 from Kinston Hughes <630dr7+9vgtozzjuj0gg at sharklasers dot com> ---
(In reply to Frank Ch. Eigler from comment #3)
> commit 100bca3f124 should fix this.  The problem here seems to be the \
> character in the string rather than new lines, but the patch nukes them both.

ah yes, a case of tunnel vision on my part. 

Thanks you again for being o responsive, I usually dread plunging into
bugzillaz for fear of either limbo or pedantic deflection but it's been simple
and quick to get hiccups in stap addressed. I salute you, sir.

-- 
You are receiving this mail because:
You are the assignee for the bug.