From: "dsmith at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sourceware.org
Subject: [Bug tapsets/22109] New: on rawhide, we're getting errors in the nfsd tapset
Date: Thu, 07 Sep 2017 18:22:00 -0000 [thread overview]
Message-ID: <bug-22109-6586@http.sourceware.org/bugzilla/> (raw)
https://sourceware.org/bugzilla/show_bug.cgi?id=22109
Bug ID: 22109
Summary: on rawhide, we're getting errors in the nfsd tapset
Product: systemtap
Version: unspecified
Status: NEW
Severity: normal
Priority: P2
Component: tapsets
Assignee: systemtap at sourceware dot org
Reporter: dsmith at redhat dot com
Target Milestone: ---
On rawhide (4.13.0-0.rc7.git4.1.fc28.x86_64), we're getting errors like these
when using the nfsd tapset:
====
# stap -p4 ../src.copy/testsuite/buildok/nfsd-detailed.stp
semantic error: while processing probe
module("nfsd").function("nfsd_proc_lookup@fs/nfsd/nfsproc.c:127") from:
nfsd.proc2.lookup from: nfsd.proc2.lookup
semantic error: not accessible at this address (pc: 0x15935) [man
error::dwarf]: identifier '$argp' at
/usr/local/share/systemtap/tapset/linux/nfsd.stp:268:15
dieoffset: 0x7e86b from
/usr/lib/debug/lib/modules/4.13.0-0.rc7.git4.1.fc28.x86_64/kernel/fs/nfsd/nfsd.ko.debug
function: nfsd_proc_lookup at fs/nfsd/nfsproc.c:128
alternative locations: [0x15950,0x15a38], [0x15a3e,0x15a72]
source: fh = & @cast($argp, "nfsd_diropargs",
"kernel:nfsd")->fh
^
semantic error: not accessible at this address (pc: 0x15935) [man
error::dwarf]: identifier '$argp' at :268:15
dieoffset: 0x7e86b from
/usr/lib/debug/lib/modules/4.13.0-0.rc7.git4.1.fc28.x86_64/kernel/fs/nfsd/nfsd.ko.debug
function: nfsd_proc_lookup at fs/nfsd/nfsproc.c:128
alternative locations: [0x15950,0x15a38], [0x15a3e,0x15a72]
source: fh = & @cast($argp, "nfsd_diropargs",
"kernel:nfsd")->fh
^
Pass 2: analysis failed. [man error::pass2]
====
At first glance, those errors looked like bad debuginfo errors, but they
aren't.
The upstream kernel has changed from functions like the following (from a RHEL6
kernel):
====
static __be32
nfsd3_proc_create(struct svc_rqst *rqstp, struct nfsd3_createargs *argp,
struct nfsd3_diropres *resp)
{
... stuff deleted ...
}
====
To the following (from the current upstream kernel):
====
static __be32
nfsd3_proc_create(struct svc_rqst *rqstp)
{
struct nfsd3_createargs *argp = rqstp->rq_argp;
struct nfsd3_diropres *resp = rqstp->rq_resp;
... stuff deleted ...
}
====
The 'argp' and 'resp' arguments got removed, but locals with the same names
were created. Systemtap has been bravely attempting to use these locals (and
succeeding at times). When trying to access 'argp' in return probes, that
failed (as it should, since we can only access function parameters in return
probes, not local variables).
The nfsd tapset should be updated to handle these upstream kernel changes.
--
You are receiving this mail because:
You are the assignee for the bug.
next reply other threads:[~2017-09-07 18:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-07 18:22 dsmith at redhat dot com [this message]
2017-09-07 19:16 ` [Bug tapsets/22109] " dsmith at redhat dot com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-22109-6586@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=systemtap@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).