From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 82781 invoked by alias); 19 Sep 2017 15:49:11 -0000 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org Received: (qmail 82704 invoked by uid 48); 19 Sep 2017 15:49:06 -0000 From: "dsmith at redhat dot com" To: systemtap@sourceware.org Subject: [Bug runtime/22158] New: on rawhide, we're getting a compile error that spin_unlock_wait() doesn't exist Date: Tue, 19 Sep 2017 15:49:00 -0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: systemtap X-Bugzilla-Component: runtime X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: dsmith at redhat dot com X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: systemtap at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter target_milestone Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2017-q3/txt/msg00215.txt.bz2 https://sourceware.org/bugzilla/show_bug.cgi?id=3D22158 Bug ID: 22158 Summary: on rawhide, we're getting a compile error that spin_unlock_wait() doesn't exist Product: systemtap Version: unspecified Status: NEW Severity: normal Priority: P2 Component: runtime Assignee: systemtap at sourceware dot org Reporter: dsmith at redhat dot com Target Milestone: --- On rawhide (4.14.0-0.rc0.git6.1.fc28.x86_64+debug), systemtap can no longer build a module, because of the following errors: =3D=3D=3D=3D # stap -e 'probe begin { exit() }' In file included from /usr/local/share/systemtap/runtime/stp_utrace.c:30:0, from /usr/local/share/systemtap/runtime/linux/task_finder2.c:4, from /usr/local/share/systemtap/runtime/linux/task_finder.c:17, from /usr/local/share/systemtap/runtime/linux/runtime.h:22= 2, from /usr/local/share/systemtap/runtime/runtime.h:26, from /tmp/stapdpP91a/stap_e2c777d95e6fc0004ae87e12eb604984_1116_src.c:25: /usr/local/share/systemtap/runtime/stp_helper_lock.h: In function =E2=80=98stp_spin_unlock_wait=E2=80=99: /usr/local/share/systemtap/runtime/stp_helper_lock.h:60:61: error: implicit declaration of function =E2=80=98spin_unlock_wait=E2=80=99; did you mean =E2=80=98stp_spin_unlock_wait=E2=80=99? [-Werror=3Dimplicit-function-declar= ation] static inline void stp_spin_unlock_wait(spinlock_t *lock) { spin_unlock_wait(lock); } ^~~~~~~~~~~~~~= ~~ =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20 stp_spin_unlock_wait cc1: all warnings being treated as errors make[1]: *** [scripts/Makefile.build:311: /tmp/stapdpP91a/stap_e2c777d95e6fc0004ae87e12eb604984_1116_src.o] Error 1 make: *** [Makefile:1516: _module_/tmp/stapdpP91a] Error 2 WARNING: kbuild exited with status: 2 Pass 4: compilation failed. [man error::pass4] =3D=3D=3D=3D This is because the following upstream kernel commit removed spin_unlock_wait(): =3D=3D=3D=3D commit d3a024abbc438277851c510b51ec9b158821488b Author: Paul E. McKenney Date: Thu Jun 29 15:47:44 2017 -0700 locking: Remove spin_unlock_wait() generic definitions There is no agreed-upon definition of spin_unlock_wait()'s semantics, and it appears that all callers could do just as well with a lock/unlock pair. This commit therefore removes spin_unlock_wait() and related definitions from core code. =3D=3D=3D=3D The systemtap runtime should be updated. --=20 You are receiving this mail because: You are the assignee for the bug.