From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 86924 invoked by alias); 15 Jun 2018 17:06:09 -0000 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org Received: (qmail 86861 invoked by uid 48); 15 Jun 2018 17:06:04 -0000 From: "mcermak at redhat dot com" To: systemtap@sourceware.org Subject: [Bug translator/22193] Regex matching (=~) should be treated as a side-effecting operation Date: Fri, 15 Jun 2018 17:06:00 -0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: systemtap X-Bugzilla-Component: translator X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: mcermak at redhat dot com X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: systemtap at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2018-q2/txt/msg00116.txt.bz2 https://sourceware.org/bugzilla/show_bug.cgi?id=3D22193 Martin Cermak changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mcermak at redhat dot com --- Comment #3 from Martin Cermak --- After the aforementioned revert, systemtap.pass1-4/runok.exp started to fai= l. It's because one of its subtests - regex_noelide.stp - started to fail. This regex_noelide.stp historically had two variants, but I do not see a difference between them from the practical point of view: variant1: 'probe begin { "foo" =3D~ "f(.)"; println(matched(1)); exit() }' variant2: 'probe begin { "foo" =3D~ "(f)oo"; println(matched(1)); exit() }' This regex_noelide.stp was created at some point but it was failing till commit 81e03c8fea, which prevented the elision. Then it was passing till f579ca5b46, which reverted 81e03c8fea. (Confusing is that both 81e03c8fea and f579ca5b46 touched regex_noelide.stp, but it was merely switching between variant1 and variant2 both of which behave the same way.) So now, after f579ca5b46, the elision happens again, and so the testcase is failing. Shouldn't it simply get dropped? --=20 You are receiving this mail because: You are the assignee for the bug.