From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4116 invoked by alias); 10 May 2018 18:01:22 -0000 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org Received: (qmail 3528 invoked by uid 48); 10 May 2018 18:00:44 -0000 From: "fche at redhat dot com" To: systemtap@sourceware.org Subject: [Bug tapsets/23160] New: 4.17 breaks syscalls tapset Date: Thu, 10 May 2018 18:01:00 -0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: systemtap X-Bugzilla-Component: tapsets X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: fche at redhat dot com X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: systemtap at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter cc target_milestone Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2018-q2/txt/msg00058.txt.bz2 https://sourceware.org/bugzilla/show_bug.cgi?id=3D23160 Bug ID: 23160 Summary: 4.17 breaks syscalls tapset Product: systemtap Version: unspecified Status: NEW Severity: normal Priority: P2 Component: tapsets Assignee: systemtap at sourceware dot org Reporter: fche at redhat dot com CC: jmoyer at redhat dot com Target Milestone: --- Kindly reported by jmoyer@rh, 4.17-rc0 as in rawhide changes the syscall wrapper functions in ways that our tapset cannot currently adapt to.=20 https://lwn.net/Articles/752422/ This kills all the syscall.* probes. One possible approach to fix is to switch our kprobes over to a new set of per-arch wrapper functions that carry parameters inside a pt_regs* pointer.= =20 Coincidentally, that is the same way that the sys_enter/sys_exit tracepoints carry individual parameters. (The __do_sys* family of functions do carry normal dwarf parameters, but cannot probe their .return because they're declared inline.) % uname -a Linux vm-rawhide-64 4.17.0-0.rc3.git4.1.fc29.x86_64 #1 SMP Fri May 4 19:41:= 58 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux % stap -L 'kernel.function("__*_accept").*'=20=20=20=20=20 kernel.function("__do_sys_accept@net/socket.c:1629").callee("__sys_accept4@= net/socket.c:1542") $fd:int $upeer_sockaddr:struct sockaddr* $upeer_addrlen:int* $flags:int $err:int $fput_needed:int $address:struct __kernel_sockaddr_storage kernel.function("__do_sys_accept@net/socket.c:1629").inline $upeer_addrlen:= int* $upeer_sockaddr:struct sockaddr* $fd:int kernel.function("__ia32_sys_accept@net/socket.c:1629").call $regs:struct pt_regs const* kernel.function("__ia32_sys_accept@net/socket.c:1629").callee("__se_sys_acc= ept@net/socket.c:1629") $upeer_addrlen:long int $upeer_sockaddr:long int $fd:long int kernel.function("__ia32_sys_accept@net/socket.c:1629").exported $regs:struct pt_regs const* kernel.function("__ia32_sys_accept@net/socket.c:1629").return $return:long = int $regs:struct pt_regs const* kernel.function("__se_sys_accept@net/socket.c:1629").inline $upeer_addrlen:= long int $upeer_sockaddr:long int $fd:long int kernel.function("__x64_sys_accept@net/socket.c:1629").call $regs:struct pt_= regs const* kernel.function("__x64_sys_accept@net/socket.c:1629").callee("__se_sys_acce= pt@net/socket.c:1629") $upeer_addrlen:long int $upeer_sockaddr:long int $fd:long int kernel.function("__x64_sys_accept@net/socket.c:1629").exported $regs:struct pt_regs const* kernel.function("__x64_sys_accept@net/socket.c:1629").return $return:long i= nt $regs:struct pt_regs const* --=20 You are receiving this mail because: You are the assignee for the bug.