* [Bug translator/23512] New: regression in --privilege=stapusr operation
@ 2018-08-10 23:40 fche at redhat dot com
2018-08-11 18:49 ` [Bug translator/23512] " agentzh at gmail dot com
2021-11-10 9:00 ` bankingservice2020 at gmail dot com
0 siblings, 2 replies; 3+ messages in thread
From: fche at redhat dot com @ 2018-08-10 23:40 UTC (permalink / raw)
To: systemtap
https://sourceware.org/bugzilla/show_bug.cgi?id=23512
Bug ID: 23512
Summary: regression in --privilege=stapusr operation
Product: systemtap
Version: unspecified
Status: NEW
Severity: normal
Priority: P2
Component: translator
Assignee: systemtap at sourceware dot org
Reporter: fche at redhat dot com
Target Milestone: ---
My commits for PR23160,PR14690 have caused a regression in the way
privilege-testing of elaboration of embedded-c tapset functions is handled.
New code changes the timing at which the /* unprivileged */ type pragmas are
processed. Now they can fail for functions like kernel_string() even though
they are not called, even transitively, from the end-user script. This breaks
e.g. the unprivileged-myproc test cases.
It turns out we run symbol elaboration in an overly inclusive manner. Any
function defined in a tapset file chosen for inclusion is fully processed, even
though it may not be transitively called at all. This represents perhaps
considerable wasted translation effort, esp. considering expensive constructs
like @cast(). We should not spend any serious efforts processing parts of
tapsets that are not reachable from the end-user script. This suggests the
resolve_syms pass must be iterative/relaxation-based, like the optimization
passes later on.
--
You are receiving this mail because:
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Bug translator/23512] regression in --privilege=stapusr operation
2018-08-10 23:40 [Bug translator/23512] New: regression in --privilege=stapusr operation fche at redhat dot com
@ 2018-08-11 18:49 ` agentzh at gmail dot com
2021-11-10 9:00 ` bankingservice2020 at gmail dot com
1 sibling, 0 replies; 3+ messages in thread
From: agentzh at gmail dot com @ 2018-08-11 18:49 UTC (permalink / raw)
To: systemtap
https://sourceware.org/bugzilla/show_bug.cgi?id=23512
agentzh <agentzh at gmail dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |agentzh at gmail dot com
--- Comment #1 from agentzh <agentzh at gmail dot com> ---
+1 for the change "resolve_syms pass must be iterative/relaxation-based". I
also need it badly for passing stat/array references around via explicit
assignments (`=`).
--
You are receiving this mail because:
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Bug translator/23512] regression in --privilege=stapusr operation
2018-08-10 23:40 [Bug translator/23512] New: regression in --privilege=stapusr operation fche at redhat dot com
2018-08-11 18:49 ` [Bug translator/23512] " agentzh at gmail dot com
@ 2021-11-10 9:00 ` bankingservice2020 at gmail dot com
1 sibling, 0 replies; 3+ messages in thread
From: bankingservice2020 at gmail dot com @ 2021-11-10 9:00 UTC (permalink / raw)
To: systemtap
https://sourceware.org/bugzilla/show_bug.cgi?id=23512
bankingservice2020 at gmail dot com changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |bankingservice2020 at gmail dot co
| |m
--
You are receiving this mail because:
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-10 9:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-10 23:40 [Bug translator/23512] New: regression in --privilege=stapusr operation fche at redhat dot com
2018-08-11 18:49 ` [Bug translator/23512] " agentzh at gmail dot com
2021-11-10 9:00 ` bankingservice2020 at gmail dot com
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).