From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <systemtap-return-26152-listarch-systemtap=sources.redhat.com@sourceware.org>
Received: (qmail 66979 invoked by alias); 10 Aug 2018 23:40:56 -0000
Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <systemtap.sourceware.org>
List-Subscribe: <mailto:systemtap-subscribe@sourceware.org>
List-Post: <mailto:systemtap@sourceware.org>
List-Help: <mailto:systemtap-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: systemtap-owner@sourceware.org
Received: (qmail 66918 invoked by uid 48); 10 Aug 2018 23:40:52 -0000
From: "fche at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sourceware.org
Subject: [Bug translator/23512] New: regression in --privilege=stapusr operation
Date: Fri, 10 Aug 2018 23:40:00 -0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: systemtap
X-Bugzilla-Component: translator
X-Bugzilla-Version: unspecified
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: fche at redhat dot com
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: systemtap at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter target_milestone
Message-ID: <bug-23512-6586@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2018-q3/txt/msg00086.txt.bz2

https://sourceware.org/bugzilla/show_bug.cgi?id=3D23512

            Bug ID: 23512
           Summary: regression in --privilege=3Dstapusr operation
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: translator
          Assignee: systemtap at sourceware dot org
          Reporter: fche at redhat dot com
  Target Milestone: ---

My commits for PR23160,PR14690 have caused a regression in the way
privilege-testing of elaboration of embedded-c tapset functions is handled.=
=20
New code changes the timing at which the /* unprivileged */ type pragmas are
processed.  Now they can fail for functions like kernel_string() even though
they are not called, even transitively, from the end-user script.  This bre=
aks
e.g. the unprivileged-myproc test cases.

It turns out we run symbol elaboration in an overly inclusive manner.  Any
function defined in a tapset file chosen for inclusion is fully processed, =
even
though it may not be transitively called at all.  This represents perhaps
considerable wasted translation effort, esp. considering expensive construc=
ts
like @cast().  We should not spend any serious efforts processing parts of
tapsets that are not reachable from the end-user script.  This suggests the
resolve_syms pass must be iterative/relaxation-based, like the optimization
passes later on.

--=20
You are receiving this mail because:
You are the assignee for the bug.