public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: "me at serhei dot io" <sourceware-bugzilla@sourceware.org>
To: systemtap@sourceware.org
Subject: [Bug bpf/23829] Bug introduced in bpf -base.cxx in git master
Date: Fri, 02 Nov 2018 20:51:00 -0000	[thread overview]
Message-ID: <bug-23829-6586-BclLvfVBPS@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-23829-6586@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=23829

--- Comment #6 from Serhei Makarov <me at serhei dot io> ---
Thanks for that info. I've tested with bpf.h from kernel 4.8. Other defines
aside from __BPF_FUNC_MAPPER and BPF_J{LT,LE,SLT,SLE} seem to be present.

The build errors reported should be fixed in commits 3d9e0d2a5 (for _F format
specifiers on 32-bit systems) and 8fb0cb4a (for undefined bpf.h symbols).
Partly fixed by adding a fallback version of __BPF_FUNC_MAPPER and fallback
defines for the new BPF_J(...) insn opcodes (these are recognized by the new
embedded-code assembler; stapbpf backend already replaces these with older
insns, so the code should work even on old kernel versions that do not support
them).

Let me know if the fixes work and I can close the bug, or if I need to refine
my workaround further.

This exposes a deeper issue, in that SystemTap/BPF must be compiled against a
recent kernel version to generate modules that use BPF features from that
version. This has also caused hiccups e.g. when building SystemTap RPM packages
in mockbuild on a kernel without eBPF support. Don't see an obvious workaround
for this.

-- 
You are receiving this mail because:
You are the assignee for the bug.

  parent reply	other threads:[~2018-11-02 20:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-26  5:38 [Bug bpf/23829] New: " gmoreira at gmail dot com
2018-10-26  5:47 ` [Bug bpf/23829] " gmoreira at gmail dot com
2018-10-29 17:54 ` me at serhei dot io
2018-10-29 17:54 ` me at serhei dot io
2018-10-31  1:02 ` gmoreira at gmail dot com
2018-10-31  1:03 ` gmoreira at gmail dot com
2018-11-02 20:51 ` me at serhei dot io [this message]
2019-03-22 19:09 ` me at serhei dot io
2019-03-27 14:48 ` me at serhei dot io

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-23829-6586-BclLvfVBPS@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=systemtap@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).