From: "me at serhei dot io" <sourceware-bugzilla@sourceware.org>
To: systemtap@sourceware.org
Subject: [Bug bpf/23875] support string map keys in foreach iteration
Date: Mon, 25 Mar 2019 16:54:00 -0000 [thread overview]
Message-ID: <bug-23875-6586-G8kCatBc30@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-23875-6586@http.sourceware.org/bugzilla/>
https://sourceware.org/bugzilla/show_bug.cgi?id=23875
--- Comment #2 from Serhei Makarov <me at serhei dot io> ---
Have some code for this, but there are regressions I need to fix. The parts
that needed to be changed so far:
- in bpf-translate.cxx, visit_foreach_loop() needs to create correctly sized
stack slots for string keys
- in bpfinterp.cxx, create a separate map_str_keys vector and use the
appropriate vectors depending on type. Some unavoidable code duplication as the
string handling code is similar but not quite the same as the code for ints.
--
You are receiving this mail because:
You are the assignee for the bug.
next prev parent reply other threads:[~2019-03-25 16:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-09 17:01 [Bug bpf/23875] New: 'stack smashing error' on " me at serhei dot io
2018-11-13 18:16 ` [Bug bpf/23875] support string map keys in " me at serhei dot io
2019-03-25 16:54 ` me at serhei dot io [this message]
2019-03-26 17:16 ` me at serhei dot io
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-23875-6586-G8kCatBc30@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=systemtap@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).