From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <systemtap-return-26628-listarch-systemtap=sources.redhat.com@sourceware.org>
Received: (qmail 8790 invoked by alias); 2 Jul 2019 18:27:13 -0000
Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <systemtap.sourceware.org>
List-Subscribe: <mailto:systemtap-subscribe@sourceware.org>
List-Post: <mailto:systemtap@sourceware.org>
List-Help: <mailto:systemtap-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: systemtap-owner@sourceware.org
Received: (qmail 8768 invoked by uid 48); 2 Jul 2019 18:27:10 -0000
From: "me at serhei dot io" <sourceware-bugzilla@sourceware.org>
To: systemtap@sourceware.org
Subject: [Bug bpf/24759] New: stapbpf-next housekeeping: need version checking between stap translator and stapbpf
Date: Tue, 02 Jul 2019 18:27:00 -0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: systemtap
X-Bugzilla-Component: bpf
X-Bugzilla-Version: unspecified
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: me at serhei dot io
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: systemtap at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter target_milestone
Message-ID: <bug-24759-6586@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2019-q3/txt/msg00001.txt.bz2

https://sourceware.org/bugzilla/show_bug.cgi?id=3D24759

            Bug ID: 24759
           Summary: stapbpf-next housekeeping: need version checking
                    between stap translator and stapbpf
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: bpf
          Assignee: systemtap at sourceware dot org
          Reporter: me at serhei dot io
  Target Milestone: ---

Currently you can generate a .bo module with one version of the systemtap
translator and feed it to a different version of stapbpf, which will dutifu=
lly
try to interpret it.

Because a lot of stapbpf feature work requires tweaks to the ELF format
(changing the ABI of stapbpf modules), this can result in nonsense behaviou=
r.
For example, pr23858 work will require changing the ABI of the
bpf_map_get_next_key helper.

We should write the stap version in a new section of the .bo file and have
stapbpf check it. By default, stapbpf should output an error (or warning) if
the versions do not match.

In future, we can look at what's required to safely enable compatibility
between different stap translator and stapbpf versions. For example, we may
want a newer translator (deployed locally, easy to update) to be able to
generate code for an older (deployed elsewhere, hard to update) stapbpf
version.

--=20
You are receiving this mail because:
You are the assignee for the bug.