public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: "me at serhei dot io" <sourceware-bugzilla@sourceware.org>
To: systemtap@sourceware.org
Subject: [Bug bpf/24812] New: stapbpf: support order-parametrized begin/end probes
Date: Mon, 15 Jul 2019 18:44:00 -0000	[thread overview]
Message-ID: <bug-24812-6586@http.sourceware.org/bugzilla/> (raw)

https://sourceware.org/bugzilla/show_bug.cgi?id=24812

            Bug ID: 24812
           Summary: stapbpf: support order-parametrized begin/end probes
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: bpf
          Assignee: systemtap at sourceware dot org
          Reporter: me at serhei dot io
  Target Milestone: ---

found this while trying to work around probe size requirement
-- so this will be important for complex bpf programs until/unless we bump the
userspace interpreter's stack size

I want two end probes to run in a specific order. Normally begin/end probe
order is unspecified but in fact you can constrain it with sequence numbers.

global flag1 = 0                                                                
global flag2 = 0                                                                

probe begin(1) {                                                                
  printf("BEGIN\n")                                                             
  flag1 = 2                                                                     
}                                                                               

probe begin(2) {                                                                
  flag1 = 1                                                                     
  exit()                                                                        
}                                                                               

probe end(1) {                                                                  
  flag2 = 2                                                                     
}                                                                               

probe end(2) {                                                                  
  flag2 = 1                                                                     
}                                                                               

probe end(3) {                                                                  
  printf("got flag1==%d flag2==%d\n", flag1, flag2)                             
  if (flag1 == 1 && flag2 == 1)                                                 
    printf("END PASS\n")                                                        
  else                                                                          
    printf("END FAIL\n")                                                        
}                                                                               

but it doesn't work on bpf.
$ sudo ~/stap-install/bin/stap probe_order.stp 
BEGIN
got flag1==1 flag2==1
END PASS

$ sudo ~/stap-install/bin/stap --bpf probe_order.stp 
BEGIN
got flag1==1 flag2==0
END FAIL

Mirrors pr3624 for the kernel backend.

-- 
You are receiving this mail because:
You are the assignee for the bug.

             reply	other threads:[~2019-07-15 18:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-15 18:44 me at serhei dot io [this message]
2019-10-25 18:50 ` [Bug bpf/24812] " sapatel at redhat dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-24812-6586@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=systemtap@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).