From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 107555 invoked by alias); 14 Aug 2019 09:42:56 -0000 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org Received: (qmail 107463 invoked by uid 48); 14 Aug 2019 09:42:52 -0000 From: "info at kleisauke dot nl" To: systemtap@sourceware.org Subject: [Bug runtime/24904] stack_trace struct undefined on kernel 5.2 Date: Wed, 14 Aug 2019 09:42:00 -0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: systemtap X-Bugzilla-Component: runtime X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: info at kleisauke dot nl X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: systemtap at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2019-q3/txt/msg00035.txt.bz2 https://sourceware.org/bugzilla/show_bug.cgi?id=3D24904 --- Comment #1 from Kleis Auke Wolthuizen --- It seems that there is also a problem with regard to perf_event_create_kernel_counter: $ stap -v -e 'global s; probe timer.profile { s[backtrace()] <<< 1; } probe= end { foreach (i in s+) { print_stack(i); printf("\t%d\n", @count(s[i])); } } p= robe timer.s(60) { exit(); }' > out.stap-stacks Pass 1: parsed user script and 488 library scripts using 355536virt/129684res/9428shr/119992data kb, in 190usr/30sys/223real ms. Pass 2: analyzed script: 3 probes, 7 functions, 1 embed, 1 global using 360024virt/134296res/9564shr/124480data kb, in 20usr/0sys/17real ms. Pass 3: translated to C into "/tmp/stapS4JOAT/stap_7a9f78085e38311a1bb8015256b67067_2952_src.c" using 360024virt/134296res/9564shr/124480data kb, in 0usr/0sys/0real ms. In file included from /tmp/stapS4JOAT/stap_7a9f78085e38311a1bb8015256b67067_2952_src.c:260: /usr/share/systemtap/runtime/stack.c:51:14: error: =E2=80=98struct stack_tr= ace=E2=80=99 declared inside parameter list will not be visible outside of this definiti= on or declaration [-Werror] 51 | struct stack_trace *trace); | ^~~~~~~~~~~ /usr/share/systemtap/runtime/stack.c: In function =E2=80=98_stp_stack_print= _fallback=E2=80=99: /usr/share/systemtap/runtime/stack.c:171:21: error: storage size of =E2=80= =98trace=E2=80=99 isn=E2=80=99t known 171 | struct stack_trace trace; | ^~~~~ In file included from /tmp/stapS4JOAT/stap_7a9f78085e38311a1bb8015256b67067_2952_src.c:1159: /usr/share/systemtap/runtime/linux/perf.c: In function =E2=80=98_stp_perf_i= nit=E2=80=99: /usr/share/systemtap/runtime/linux/perf.c:49:18: error: passing argument 3 = of =E2=80=98perf_event_create_kernel_counter=E2=80=99 makes pointer from integ= er without a cast [-Werror=3Dint-conversion] 49 | task->pid, | ~~~~^~~~~ | | | pid_t {aka int} In file included from /usr/share/systemtap/runtime/linux/runtime.h:236, from /usr/share/systemtap/runtime/runtime.h:26, from /tmp/stapS4JOAT/stap_7a9f78085e38311a1bb8015256b67067_2952_src.c:28: ./include/linux/perf_event.h:899:1: note: expected =E2=80=98struct task_str= uct *=E2=80=99 but argument is of type =E2=80=98pid_t=E2=80=99 {aka =E2=80=98int=E2=80=99} 899 | perf_event_create_kernel_counter(struct perf_event_attr *attr, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from /tmp/stapS4JOAT/stap_7a9f78085e38311a1bb8015256b67067_2952_src.c:1159: /usr/share/systemtap/runtime/linux/perf.c:44:34: error: too few arguments to function =E2=80=98perf_event_create_kernel_counter=E2=80=99 44 | stp->e.t.per_thread_event =3D perf_event_create_kernel_counter(&stp->attr, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from /usr/share/systemtap/runtime/linux/runtime.h:236, from /usr/share/systemtap/runtime/runtime.h:26, from /tmp/stapS4JOAT/stap_7a9f78085e38311a1bb8015256b67067_2952_src.c:28: ./include/linux/perf_event.h:899:1: note: declared here 899 | perf_event_create_kernel_counter(struct perf_event_attr *attr, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from /tmp/stapS4JOAT/stap_7a9f78085e38311a1bb8015256b67067_2952_src.c:1159: /usr/share/systemtap/runtime/linux/perf.c:100:13: error: passing argument 3= of =E2=80=98perf_event_create_kernel_counter=E2=80=99 makes pointer from integ= er without a cast [-Werror=3Dint-conversion] 100 | -1, | ^~ | | | int In file included from /usr/share/systemtap/runtime/linux/runtime.h:236, from /usr/share/systemtap/runtime/runtime.h:26, from /tmp/stapS4JOAT/stap_7a9f78085e38311a1bb8015256b67067_2952_src.c:28: ./include/linux/perf_event.h:899:1: note: expected =E2=80=98struct task_str= uct *=E2=80=99 but argument is of type =E2=80=98int=E2=80=99 899 | perf_event_create_kernel_counter(struct perf_event_attr *attr, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from /tmp/stapS4JOAT/stap_7a9f78085e38311a1bb8015256b67067_2952_src.c:1159: /usr/share/systemtap/runtime/linux/perf.c:95:15: error: too few arguments to function =E2=80=98perf_event_create_kernel_counter=E2=80=99 95 | *event =3D perf_event_create_kernel_counter(&stp->attr, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from /usr/share/systemtap/runtime/linux/runtime.h:236, from /usr/share/systemtap/runtime/runtime.h:26, from /tmp/stapS4JOAT/stap_7a9f78085e38311a1bb8015256b67067_2952_src.c:28: ./include/linux/perf_event.h:899:1: note: declared here 899 | perf_event_create_kernel_counter(struct perf_event_attr *attr, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors make[1]: *** [scripts/Makefile.build:278: /tmp/stapS4JOAT/stap_7a9f78085e38311a1bb8015256b67067_2952_src.o] Error 1 make: *** [Makefile:1601: _module_/tmp/stapS4JOAT] Error 2 WARNING: kbuild exited with status: 2 Pass 4: compiled C into "stap_7a9f78085e38311a1bb8015256b67067_2952.ko" in 6780usr/1500sys/8282real ms. Pass 4: compilation failed. [man error::pass4] --=20 You are receiving this mail because: You are the assignee for the bug.