public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: "info at kleisauke dot nl" <sourceware-bugzilla@sourceware.org>
To: systemtap@sourceware.org
Subject: [Bug runtime/24904] New: stack_trace struct undefined on kernel 5.2
Date: Tue, 13 Aug 2019 15:20:00 -0000	[thread overview]
Message-ID: <bug-24904-6586@http.sourceware.org/bugzilla/> (raw)

https://sourceware.org/bugzilla/show_bug.cgi?id=24904

            Bug ID: 24904
           Summary: stack_trace struct undefined on kernel 5.2
           Product: systemtap
           Version: unspecified
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: runtime
          Assignee: systemtap at sourceware dot org
          Reporter: info at kleisauke dot nl
  Target Milestone: ---

print_ubacktrace() is broken on Fedora 30, with kernel 5.2.7-200 and systemtap
4.1-1.

$ stap -v -e 'probe process.function("*") { print_ubacktrace(); exit() }' -x
1087
Pass 1: parsed user script and 488 library scripts using
355536virt/129556res/9300shr/119992data kb, in 190usr/40sys/223real ms.
Pass 2: analyzed script: 5181 probes, 2 functions, 0 embeds, 0 globals using
379508virt/154036res/10196shr/143964data kb, in 110usr/0sys/133real ms.
Pass 3: translated to C into
"/tmp/stapxd395N/stap_750ab0efc72dfcc1dbb01db1071e2bf9_1742296_src.c" using
381044virt/155896res/10452shr/145500data kb, in 120usr/40sys/165real ms.
In file included from
/tmp/stapxd395N/stap_750ab0efc72dfcc1dbb01db1071e2bf9_1742296_src.c:90:
/usr/share/systemtap/runtime/stack.c:51:14: error: ‘struct stack_trace’
declared inside parameter list will not be visible outside of this definition
or declaration [-Werror]
   51 |       struct stack_trace *trace);
      |              ^~~~~~~~~~~
/usr/share/systemtap/runtime/stack.c: In function ‘_stp_stack_print_fallback’:
/usr/share/systemtap/runtime/stack.c:171:21: error: storage size of ‘trace’
isn’t known
  171 |  struct stack_trace trace;
      |                     ^~~~~
cc1: all warnings being treated as errors
make[1]: *** [scripts/Makefile.build:278:
/tmp/stapxd395N/stap_750ab0efc72dfcc1dbb01db1071e2bf9_1742296_src.o] Error 1
make: *** [Makefile:1601: _module_/tmp/stapxd395N] Error 2
WARNING: kbuild exited with status: 2
Pass 4: compiled C into "stap_750ab0efc72dfcc1dbb01db1071e2bf9_1742296.ko" in
6970usr/1440sys/8406real ms.
Pass 4: compilation failed.  [man error::pass4]

It seems that the root cause of this is due to this commit:
https://github.com/torvalds/linux/commit/214d8ca6ee854f696f75e75511fe66b409e656db#diff-ba4af21f3a043f2139272bcc0bced588R64

(if ARCH_STACKWALK is set, the stack_trace struct is undefined)

-- 
You are receiving this mail because:
You are the assignee for the bug.

             reply	other threads:[~2019-08-13 15:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-13 15:20 info at kleisauke dot nl [this message]
2019-08-14  9:42 ` [Bug runtime/24904] " info at kleisauke dot nl
2019-08-21  1:38 ` fche at redhat dot com
2019-08-21  1:39 ` fche at redhat dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-24904-6586@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=systemtap@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).