From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 59249 invoked by alias); 30 Aug 2019 20:20:15 -0000 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org Received: (qmail 59119 invoked by uid 48); 30 Aug 2019 20:20:10 -0000 From: "sapatel at redhat dot com" To: systemtap@sourceware.org Subject: [Bug bpf/24946] printing hex sequences causes crash Date: Fri, 30 Aug 2019 20:20:00 -0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: systemtap X-Bugzilla-Component: bpf X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: sapatel at redhat dot com X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: systemtap at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2019-q3/txt/msg00056.txt.bz2 https://sourceware.org/bugzilla/show_bug.cgi?id=3D24946 --- Comment #1 from Sagar Patel --- The translation in stapbpf causes the iterator to reach the end of the stri= ng after building the hex number, and then loop increments the iterator again = and misses the stopping condition. This causes the loop to go out of range and eventually run into a segmentation fault. Additionally, the building of the hex number doesn't account for digits '8'= and '9', and as mentioned in PR24947 there is no check for valid hex sequences. --=20 You are receiving this mail because: You are the assignee for the bug.