From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <systemtap-return-26836-listarch-systemtap=sources.redhat.com@sourceware.org>
Received: (qmail 77598 invoked by alias); 21 Feb 2020 03:48:52 -0000
Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <systemtap.sourceware.org>
List-Subscribe: <mailto:systemtap-subscribe@sourceware.org>
List-Post: <mailto:systemtap@sourceware.org>
List-Help: <mailto:systemtap-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: systemtap-owner@sourceware.org
Received: (qmail 77158 invoked by uid 48); 21 Feb 2020 03:48:23 -0000
From: "dale.hamel at srvthe dot net" <sourceware-bugzilla@sourceware.org>
To: systemtap@sourceware.org
Subject: [Bug releng/25581] USDT probes when /proc/[pid]/mem not writeable
Date: Fri, 21 Feb 2020 03:48:00 -0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: systemtap
X-Bugzilla-Component: releng
X-Bugzilla-Version: unspecified
X-Bugzilla-Keywords:
X-Bugzilla-Severity: enhancement
X-Bugzilla-Who: dale.hamel at srvthe dot net
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: systemtap at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: attachments.isobsolete attachments.created
Message-ID: <bug-25581-6586-x5nRICiUmQ@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-25581-6586@http.sourceware.org/bugzilla/>
References: <bug-25581-6586@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2020-q1/txt/msg00045.txt

https://sourceware.org/bugzilla/show_bug.cgi?id=3D25581

Dale Hamel <dale.hamel at srvthe dot net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #12306|0                           |1
        is obsolete|                            |

--- Comment #5 from Dale Hamel <dale.hamel at srvthe dot net> ---
Created attachment 12307
  --> https://sourceware.org/bugzilla/attachment.cgi?id=3D12307&action=3Ded=
it
Additional fixes

Ran it and double checked the generated headers.

Sample without -S flag:

```

/* RUBY_METHOD_ENTRY ( const char *classname, const char *methodname, const
char *filename, int lineno ) */
#if defined STAP_SDT_V1
#define ruby_method__entry_semaphore method__entry_semaphore
#else
#define RUBY_METHOD_ENTRY_ENABLED() __builtin_expect
(ruby_method__entry_semaphore, 0)
#endif
__extension__ extern unsigned short ruby_method__entry_semaphore __attribut=
e__
((unused)) __attribute__ ((section (".probes")));
#define RUBY_METHOD_ENTRY(arg1, arg2, arg3, arg4) \
DTRACE_PROBE4 (ruby, method__entry, arg1, arg2, arg3, arg4)

```

With the -S flag:

```

#define _SDT_HAS_SEMAPHORES 0


#define STAP_HAS_SEMAPHORES 0 /* deprecated */

#define __PLATFORM_UPROBE_ENABLED(provider, name)\
   provider##_##name##_check !=3D 0 && \
   ((*(char *) __##provider##_##name##_asm_check) & 0x90) !=3D 0x90


#include <sys/sdt.h>

/* RUBY_METHOD_ENTRY ( const char *classname, const char *methodname, const
char *filename, int lineno ) */
#define RUBY_METHOD_ENTRY_ENABLED() __PLATFORM_UPROBE_ENABLED(ruby,
method__entry)
#define RUBY_METHOD_ENTRY(arg1, arg2, arg3, arg4) \
DTRACE_PROBE4 (ruby, method__entry, arg1, arg2, arg3, arg4)

void __ruby_method__entry_asm_check();
```

--=20
You are receiving this mail because:
You are the assignee for the bug.