From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 29484394201E; Tue, 17 Mar 2020 14:12:47 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 29484394201E
From: "craig.ringer at 2ndquadrant dot com"
 <sourceware-bugzilla@sourceware.org>
To: systemtap@sourceware.org
Subject: [Bug tapsets/25686] New: user_buffer_quoted incorrectly
 octal-escapes non-printable characters
Date: Tue, 17 Mar 2020 14:12:46 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: systemtap
X-Bugzilla-Component: tapsets
X-Bugzilla-Version: unspecified
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: craig.ringer at 2ndquadrant dot com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: systemtap at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status
 bug_severity priority component assigned_to reporter target_milestone
Message-ID: <bug-25686-6586@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: systemtap@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Systemtap mailing list <systemtap.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/systemtap>,
 <mailto:systemtap-request@sourceware.org?subject=unsubscribe>
List-Archive: <http://sourceware.org/pipermail/systemtap/>
List-Help: <mailto:systemtap-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/systemtap>,
 <mailto:systemtap-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 17 Mar 2020 14:12:47 -0000

https://sourceware.org/bugzilla/show_bug.cgi?id=3D25686

            Bug ID: 25686
           Summary: user_buffer_quoted incorrectly octal-escapes
                    non-printable characters
           Product: systemtap
           Version: unspecified
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: tapsets
          Assignee: systemtap at sourceware dot org
          Reporter: craig.ringer at 2ndquadrant dot com
  Target Milestone: ---

`user_buffer_quoted` omits leading zeroes from octal escapes even when the =
next
character is a printable digit. This leads to incorrectly escaped data.

E.g. given the buffer `1\x006\x00` i.e. hex-representation `31 00 36 00`,
`user_buffer_quoted` will emit `1\06\0`. This will decode to hex-bytes `31 =
06
00` because the sequence `\06` is interpreted as "octal 06" not "octal 0, t=
hen
ascii printable digit 6".

The underlying bug appears to be in `_stp_text_str`.

--=20
You are receiving this mail because:
You are the assignee for the bug.=