From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id D88093890403; Mon, 29 Jun 2020 15:39:32 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D88093890403 From: "wcohen at redhat dot com" To: systemtap@sourceware.org Subject: [Bug tapsets/26152] _struct_compat_timex_u() function doesn't work on rhel8 Date: Mon, 29 Jun 2020 15:39:32 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: systemtap X-Bugzilla-Component: tapsets X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: wcohen at redhat dot com X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: systemtap at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: systemtap@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Systemtap mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Jun 2020 15:39:33 -0000 https://sourceware.org/bugzilla/show_bug.cgi?id=3D26152 --- Comment #1 from William Cohen --- git bisect showed that the problem occurs due to: commit 4ab42baafca69953229422923ec0721abebb570f Author: Frank Ch. Eigler Date: Wed Dec 11 15:28:46 2019 -0500 tapset: _struct_compat_timex_u() support after renaming to old_timex32 Kernel commit 4d5f007eedb74d (v5.1+) renames the old compat_timex structure to old_timex32. The CONFIG_COMPAT_32BIT_TIME was added to kernels before struct old_timex32. CONFIG_COMPAT_32BIT_TIME available in 4.18 kenels, but old_timex32 wasn't a= dded to kernels until: Author: Arnd Bergmann 2019-01-02 07:28:47 Committer: Arnd Bergmann 2019-02-06 18:13:27 Parent: 805089c2f77047d81f47ddc227435d606ceb180e (syscalls: remove obsolete __IGNORE_ macros) Child: 2c620ff93d9fbd5d644760d4c21d389078ec1080 (time: Add struct __kernel_timex) Branches: master, remotes/origin/master, wcohen/gcc9 Follows: v5.0-rc2 Precedes: v5.1-rc1 time: make adjtime compat handling available for 32 bit We want to reuse the compat_timex handling on 32-bit architectures the same way we are using the compat handling for timespec when moving to 64-bit time_t. Move all definitions related to compat_timex out of the compat code into the normal timekeeping code, along with a rename to old_timex32, corresponding to the timespec/timeval structures, and make it controlled by CONFIG_COMPAT_32BIT_TIME, which 32-bit architectures will then selec= t. Signed-off-by: Arnd Bergmann --=20 You are receiving this mail because: You are the assignee for the bug.=