public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: "m.j.harvey at imperial dot ac.uk" <sourceware-bugzilla@sourceware.org>
To: systemtap@sourceware.org
Subject: [Bug tapsets/26666] New: nfsd tapset - fh_export and fh_dentry always NULL for NFSv3
Date: Fri, 25 Sep 2020 18:03:50 +0000	[thread overview]
Message-ID: <bug-26666-6586@http.sourceware.org/bugzilla/> (raw)

https://sourceware.org/bugzilla/show_bug.cgi?id=26666

            Bug ID: 26666
           Summary: nfsd tapset - fh_export and fh_dentry always NULL for
                    NFSv3
           Product: systemtap
           Version: unspecified
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: tapsets
          Assignee: systemtap at sourceware dot org
          Reporter: m.j.harvey at imperial dot ac.uk
  Target Milestone: ---

Hi,

When using the nfsd.proc.entries probes, fh->fh_dentry and fh->fh_export are
always NULL when the NFS version is 3. This makes it impossible to resolve the
full path of a file. When the NFS version is 4, this members are set as
expected and task_dentry_path(), inode_path() work as expected.

To reproduce:

Set up an NFS export, mount it as nfsv3
On the server run stap --all-modules
share/systemtap/examples/network/nfsd-trace.stp 
On the client touch a new file on the mount
Onthe server note stap abort with
ERROR: read fault [man error::fault] at 0x38 near operator '->' at
nfsd-trace.stp:18:31

Remount with nfsv4, and repeat. Observe that the tap reports accesses
correctly.

adding printf("%s %s", fh->fh_dentry, fh->fh_export) and repeating confirms the
difference.

Tested on RHEL 7.8 x86-64, kernel 3.10.0-1127.19.1, with RHEL systemtap 4.0 and
also current  git head (747902ed).

-- 
You are receiving this mail because:
You are the assignee for the bug.

             reply	other threads:[~2020-09-25 18:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-25 18:03 m.j.harvey at imperial dot ac.uk [this message]
2020-09-25 23:06 ` [Bug tapsets/26666] " m.j.harvey at imperial dot ac.uk
2020-09-25 23:36 ` fche at redhat dot com
2020-09-29 17:12 ` m.j.harvey at imperial dot ac.uk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-26666-6586@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=systemtap@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).