From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 7758A385782C; Mon, 18 Jan 2021 12:06:12 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7758A385782C
From: "tbaeder at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sourceware.org
Subject: [Bug server/26839] Systemtap build failures with clang
Date: Mon, 18 Jan 2021 12:06:12 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: systemtap
X-Bugzilla-Component: server
X-Bugzilla-Version: unspecified
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: tbaeder at redhat dot com
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: systemtap at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-26839-6586-bgG0lCb2aj@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-26839-6586@http.sourceware.org/bugzilla/>
References: <bug-26839-6586@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: systemtap@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Systemtap mailing list <systemtap.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/systemtap>,
 <mailto:systemtap-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/systemtap/>
List-Help: <mailto:systemtap-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/systemtap>,
 <mailto:systemtap-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Mon, 18 Jan 2021 12:06:12 -0000

https://sourceware.org/bugzilla/show_bug.cgi?id=3D26839

--- Comment #6 from Timm B=C3=A4der <tbaeder at redhat dot com> ---
Adding the GCC diagnostic pragmas to the printf-like functions was wrong btw
and just adding the appropriate __attribute__((format(printf, x, y)))
attributes is better, fixes the problems with clang and gives us better err=
or
reporting.

It also shows a few problems with the current un-annotated functions like t=
his
one in staprun/relay.c:

--- a/staprun/relay.c
+++ b/staprun/relay.c
@@ -272,7 +272,7 @@ static void switchfile_handler(int sig)
                pthread_mutex_lock(&mutex[avail_cpus[i]]);
                if (reader[avail_cpus[i]] && switch_file[avail_cpus[i]]) {
                        pthread_mutex_unlock(&mutex[avail_cpus[i]]);
-                       dbug(2, "file switching is progressing, signal
ignored.\n", sig);
+                       dbug(2, "file switching is progressing, signal %d
ignored.\n", sig);
                        return;
                }
                pthread_mutex_unlock(&mutex[avail_cpus[i]]);
diff --git a/staprun/staprun.h b/staprun/staprun.h


Frank, do you have an opinion about the printsig() issue? Or should I just =
post
the patches I already have?


Thanks,
Timm

--=20
You are receiving this mail because:
You are the assignee for the bug.=