From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 8785E3854812; Wed, 4 Nov 2020 08:27:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8785E3854812 From: "tbaeder at redhat dot com" To: systemtap@sourceware.org Subject: [Bug server/26839] New: Systemtap build failures with clang Date: Wed, 04 Nov 2020 08:27:02 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: systemtap X-Bugzilla-Component: server X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: tbaeder at redhat dot com X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: systemtap at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter target_milestone Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: systemtap@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Systemtap mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Nov 2020 08:27:02 -0000 https://sourceware.org/bugzilla/show_bug.cgi?id=3D26839 Bug ID: 26839 Summary: Systemtap build failures with clang Product: systemtap Version: unspecified Status: NEW Severity: normal Priority: P2 Component: server Assignee: systemtap at sourceware dot org Reporter: tbaeder at redhat dot com Target Milestone: --- systemtap currently fails to build with clang. $ clang --version clang version 10.0.1 (Fedora 10.0.1-3.fc32) Target: x86_64-unknown-linux-gnu Thread model: posix InstalledDir: /usr/bin The output is (I tried deduplicating): ./elaborate.h:47:1: error: 'symresolution_info' defined as a struct here but previously declared as a class; this is valid, but may result in linker err= ors under the Microsoft C++ ABI [-Werror,-Wmismatched-tags] struct symresolution_info: public traversing_visitor ^ ./session.h:126:1: note: did you mean struct here? class symresolution_info; ^~~~~ struct ./elaborate.h:206:16: error: 'derived_probe::printsig' hides overloaded vir= tual function [-Werror,-Woverloaded-virtual] virtual void printsig (std::ostream &o, bool nest=3Dtrue) const; ^ ./staptree.h:913:16: note: hidden overloaded virtual function 'probe::print= sig' declared here: different number of parameters (1 vs 2) virtual void printsig (std::ostream &o) const; ^ 2 errors generated. ./dwflpp.h:185:1: error: struct 'location_context' was previously declared = as a class; this is valid, but may result in linker errors under the Microsoft C= ++ ABI [-Werror,-Wmismatched-tags] struct location_context; ^ ./loc2stap.h:45:7: note: previous use is here class location_context ^ ./dwflpp.h:185:1: note: did you mean class here? struct location_context; ^~~~~~ class ./dwflpp.h:187:1: error: 'dwflpp' defined as a struct here but previously declared as a class; this is valid, but may result in linker errors under t= he Microsoft C++ ABI [-Werror,-Wmismatched-tags] struct dwflpp ^ ./loc2stap.h:44:1: note: did you mean struct here? class dwflpp; ^~~~~ struct translate.cxx:303:8: error: 'emit_function' overrides a member function but= is not marked 'override' [-Werror,-Winconsistent-missing-override] void emit_function (functiondecl* fd); ^ translate.cxx:155:8: note: overridden virtual function is here void emit_function (functiondecl* v); ^ translate.cxx:304:8: error: 'emit_probe' overrides a member function but is= not marked 'override' [-Werror,-Winconsistent-missing-override] void emit_probe (derived_probe* dp); ^ translate.cxx:161:8: note: overridden virtual function is here void emit_probe (derived_probe* v); ^ util.cxx:1545:28: error: taking the absolute value of unsigned type 'unsign= ed long' has no effect [-Werror,-Wabsolute-value] unsigned min_score =3D labs(target.size() - it->size()); ^ util.cxx:1545:28: note: remove the call to 'labs' since unsigned values can= not be negative unsigned min_score =3D labs(target.size() - it->size()); ^~~~ Fixing the class/struct mixups is easy and shouldn't cause any problems. I'm not so sure about the others though. How do you handle the missing over= ride or the hidden overloaded virtual function in this codebase? I can work on t= his if it's easier for you. Thanks --=20 You are receiving this mail because: You are the assignee for the bug.=