public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: "craig.ringer at 2ndquadrant dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sourceware.org
Subject: [Bug testsuite/27185] Reduce code duplication in conversions stress tests
Date: Mon, 18 Jan 2021 03:28:07 +0000	[thread overview]
Message-ID: <bug-27185-6586-BDnJKoezmK@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-27185-6586@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=27185

--- Comment #2 from Craig Ringer <craig.ringer at 2ndquadrant dot com> ---
Wasn't sure how I could use macros given that I wanted to contain the whole
probe body - make the individual test lines the same across all the similar
tests to allow a simple copy/paste, and make it possible to generate them
from a common template file later.

Thanks for merging.

On Sat, 16 Jan 2021 at 08:11, fche at redhat dot com <
sourceware-bugzilla@sourceware.org> wrote:

> https://sourceware.org/bugzilla/show_bug.cgi?id=27185
>
> Frank Ch. Eigler <fche at redhat dot com> changed:
>
>            What    |Removed                     |Added
>
> ----------------------------------------------------------------------------
>          Resolution|---                         |FIXED
>              Status|UNCONFIRMED                 |RESOLVED
>                  CC|                            |fche at redhat dot com
>
> --- Comment #1 from Frank Ch. Eigler <fche at redhat dot com> ---
> Thanks, merged.
> (Could probably have represented the
> common code with functions rather than macros.)
>
> --
> You are receiving this mail because:
> You reported the bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.

      parent reply	other threads:[~2021-01-18  3:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-15  1:53 [Bug testsuite/27185] New: " craig.ringer at 2ndquadrant dot com
2021-01-15  1:56 ` [Bug testsuite/27185] " craig.ringer at 2ndquadrant dot com
2021-01-16  0:11 ` fche at redhat dot com
2021-01-18  3:28 ` craig.ringer at 2ndquadrant dot com [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-27185-6586-BDnJKoezmK@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=systemtap@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).