[Bug testsuite/27185] New: Reduce code duplication in conversions stress tests

[Bug testsuite/27185] New: Reduce code duplication in conversions stress tests

[craig.ringer at 2ndquadrant dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27185

            Bug ID: 27185
           Summary: Reduce code duplication in conversions stress tests
           Product: systemtap
           Version: unspecified
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: testsuite
          Assignee: systemtap at sourceware dot org
          Reporter: craig.ringer at 2ndquadrant dot com
  Target Milestone: ---

Created attachment 13119
  --> https://sourceware.org/bugzilla/attachment.cgi?id=13119&action=edit
conversions.exp test enhancements

Hi

I've adjusted the stress tests referenced in
testsuite/systemtap.stress/conversions.exp to make them more concise and allow
all the test definitions to be shared across each variant.

It should be practical to further condense them by extracting the common part
into a shared file to include in each tapset and reusing the macros. But I
haven't bothered with that. At least now if you update the tests, you can just
copy/paste the new or changed test lines to all of conversions.stp,
conversions_trace.stp, conversions_profile.stp, and conversions_perf.stp
without having to rewrite everything in each one.

I also added unique probe identifiers to each one, so that on failure it's
possible to tell which test failed.

There's also now validation of whether a specific function call throws an error
that aborts the probe body or not. If something that should throw an error does
not, test output will be produced that lets you map that back to the specific
test case.

This is my first time using dejagnu and expect, but hopefully it's useful.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug testsuite/27185] Reduce code duplication in conversions stress tests

[craig.ringer at 2ndquadrant dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27185

Craig Ringer <craig.ringer at 2ndquadrant dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug testsuite/27185] Reduce code duplication in conversions stress tests

[fche at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27185

Frank Ch. Eigler <fche at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |fche at redhat dot com

--- Comment #1 from Frank Ch. Eigler <fche at redhat dot com> ---
Thanks, merged.
(Could probably have represented the
common code with functions rather than macros.)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug testsuite/27185] Reduce code duplication in conversions stress tests

[craig.ringer at 2ndquadrant dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27185

--- Comment #2 from Craig Ringer <craig.ringer at 2ndquadrant dot com> ---
Wasn't sure how I could use macros given that I wanted to contain the whole
probe body - make the individual test lines the same across all the similar
tests to allow a simple copy/paste, and make it possible to generate them
from a common template file later.

Thanks for merging.

On Sat, 16 Jan 2021 at 08:11, fche at redhat dot com <
sourceware-bugzilla@sourceware.org> wrote:

> https://sourceware.org/bugzilla/show_bug.cgi?id=27185
>
> Frank Ch. Eigler <fche at redhat dot com> changed:
>
>            What    |Removed                     |Added
>
> ----------------------------------------------------------------------------
>          Resolution|---                         |FIXED
>              Status|UNCONFIRMED                 |RESOLVED
>                  CC|                            |fche at redhat dot com
>
> --- Comment #1 from Frank Ch. Eigler <fche at redhat dot com> ---
> Thanks, merged.
> (Could probably have represented the
> common code with functions rather than macros.)
>
> --
> You are receiving this mail because:
> You reported the bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.