[Bug documentation/27803] New: doc/SystemTap_Tapset_Reference/tapsets.pdf is removed during cleaning but not rebuilt

[Bug documentation/27803] New: doc/SystemTap_Tapset_Reference/tapsets.pdf is removed during cleaning but not rebuilt

[ddstreet at canonical dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27803

            Bug ID: 27803
           Summary: doc/SystemTap_Tapset_Reference/tapsets.pdf is removed
                    during cleaning but not rebuilt
           Product: systemtap
           Version: unspecified
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: documentation
          Assignee: systemtap at sourceware dot org
          Reporter: ddstreet at canonical dot com
  Target Milestone: ---

The file "doc/SystemTap_Tapset_Reference/tapsets.pdf" is included in the make
target "clean-generic", since it's included in $CLEANFILES, along with
tapsets.xml

However, unlike tapsets.xml, there is no rule to remake this file, so after
cleaning the build will fail since tapsets.pdf doesn't exist.

It appears to be built from the scripts/update-docs script, but nothing in the
build actually calls that, that I can find.

Should tapsets.pdf get rebuild during the build, or should it be removed from
$CLEANFILES

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug documentation/27803] doc/SystemTap_Tapset_Reference/tapsets.pdf is removed during cleaning but not rebuilt

[wcohen at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27803

William Cohen <wcohen at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |wcohen at redhat dot com

--- Comment #1 from William Cohen <wcohen at redhat dot com> ---
This should be addressed by the following commit:

commit ec6c1f93353e5a0f095943bc8bfe3c7749b9c9b7 (HEAD -> master)
Author: William Cohen <wcohen@redhat.com>
Date:   Wed Dec 6 16:36:42 2023 -0500

    PR27803: Do not remove doc/SystemTap_Tapset_Reference/tapsets.pdf

    The "make clean" would remove tapsets.pdf and the "make" does
    not rebuild it.  tapsets.pdf is built using some other scripts
    and is checked into the SystemTap git repository.  Changing
    the Makefile.am and Makefile.in to avoid removing tapsets.pdf

-- 
You are receiving this mail because:
You are the assignee for the bug.