From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 061C5385E447; Tue,  4 May 2021 04:29:25 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 061C5385E447
From: "agentzh at gmail dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sourceware.org
Subject: [Bug bpf/27819] New: The current string literal limit for the bpf
 mode is too conservative
Date: Tue, 04 May 2021 04:29:25 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: systemtap
X-Bugzilla-Component: bpf
X-Bugzilla-Version: unspecified
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: agentzh at gmail dot com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: systemtap at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status
 bug_severity priority component assigned_to reporter target_milestone
Message-ID: <bug-27819-6586@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: systemtap@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Systemtap mailing list <systemtap.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/systemtap>,
 <mailto:systemtap-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/systemtap/>
List-Help: <mailto:systemtap-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/systemtap>,
 <mailto:systemtap-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 04 May 2021 04:29:28 -0000

https://sourceware.org/bugzilla/show_bug.cgi?id=3D27819

            Bug ID: 27819
           Summary: The current string literal limit for the bpf mode is
                    too conservative
           Product: systemtap
           Version: unspecified
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: bpf
          Assignee: systemtap at sourceware dot org
          Reporter: agentzh at gmail dot com
  Target Milestone: ---

Seems like the current string literal limit is very easy to exceed:

```
$ /opt/stap/bin/stap --bpf -e 'probe oneshot { error("you cannot specify op=
tion
A and option B at the same time! Try something else.") }'
semantic error: string literal too long: string 'you cannot specify option A
and option B at the same time! Try something else.' at <input>:1:23
        source: probe oneshot { error( ... you cannot specify option A and
option B at the same time! Try something else. ... "you cannot specify opti=
on A
and option B at the same time! Try something else.") }
                                           ^

Pass 4: compilation failed.  [man error::pass4]
```

For comparison, the same oneliner works with the kernel runtime:

```
$ /opt/stap/bin/stap -e 'probe oneshot { error("you cannot specify option A=
 and
option B at the same time! Try something else.") }'
ERROR: you cannot specify option A and option B at the same time! Try somet=
hing
else.
WARNING: Number of errors: 1, skipped probes: 0
WARNING: /opt/stap/bin/staprun exited with status: 1
Pass 5: run failed.  [man error::pass5]
```

More information:

```
$ /opt/stap/bin/stap -V
Systemtap translator/driver (version 4.5/0.183, commit
release-4.4-145-g8ae1d1dcec48)
Copyright (C) 2005-2020 Red Hat, Inc. and others
This is free software; see the source for copying conditions.
tested kernel versions: 2.6.32 ... 5.12.0-rc
enabled features: BPF
```

And I'm using kernel 5.10.15 built from mainline source on Fedora x86_64.

--=20
You are receiving this mail because:
You are the assignee for the bug.=