From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 5D0AA38460A2; Fri,  7 May 2021 02:06:15 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5D0AA38460A2
From: "fche at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sourceware.org
Subject: [Bug translator/27829] New: support for floating point values passed
 through sdt.h markers
Date: Fri, 07 May 2021 02:06:15 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: systemtap
X-Bugzilla-Component: translator
X-Bugzilla-Version: unspecified
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: fche at redhat dot com
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: systemtap at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status
 bug_severity priority component assigned_to reporter target_milestone
 attachments.created
Message-ID: <bug-27829-6586@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: systemtap@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Systemtap mailing list <systemtap.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/systemtap>,
 <mailto:systemtap-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/systemtap/>
List-Help: <mailto:systemtap-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/systemtap>,
 <mailto:systemtap-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Fri, 07 May 2021 02:06:15 -0000

https://sourceware.org/bugzilla/show_bug.cgi?id=3D27829

            Bug ID: 27829
           Summary: support for floating point values passed through sdt.h
                    markers
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: translator
          Assignee: systemtap at sourceware dot org
          Reporter: fche at redhat dot com
  Target Milestone: ---

Created attachment 13422
  --> https://sourceware.org/bugzilla/attachment.cgi?id=3D13422&action=3Ded=
it
partial patch

While stap has recently developed the ability access floating point paramet=
ers
passed through dwarf-designated locations, we can't do that for sdt.h.  Tha=
t's
for a couple of reasons:=20

- tapsets.cxx sdt_uprobe_var_expanding_visitor::build_dwarf_registers does =
not
recognize FP register names
- includes/sys/sdt.h uses an STAP_SDT_ARG_CONSTRAINT that excludes FP regis=
ters
(so FP values are copied into integer registers anyway)
- includes/sys/sdt.h has no way of marking up floating-point vs integer
registers

A partial patch for the first two parts is attached, for x86-64.
The latter requires some coordination with other sdt.h consumers, in order =
to
parse a modification of the operand description syntax.  One possibility:

Instead of:

% readelf -n stap
stapsdt              0x0000003b       NT_STAPSDT (SystemTap probe descripto=
rs)
[...]
    Arguments: 8@%xmm0 4@%xmm1

use:

stapsdt              0x0000003b       NT_STAPSDT (SystemTap probe descripto=
rs)
[...]
    Arguments: 8f@%xmm0 4f@%xmm1

i.e., insert an "f" char between the length and the "@" sign.  We could/sho=
uld
do that even if the floats were copied into an integer register due to oper=
and
constraints.

--=20
You are receiving this mail because:
You are the assignee for the bug.=