From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 000313858D35; Fri, 25 Feb 2022 16:06:41 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 000313858D35
From: "dannf at dannf dot org" <sourceware-bugzilla@sourceware.org>
To: systemtap@sourceware.org
Subject: [Bug uprobes/28923] dtrace predictable temp file causes race
Date: Fri, 25 Feb 2022 16:06:41 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: systemtap
X-Bugzilla-Component: uprobes
X-Bugzilla-Version: unspecified
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: dannf at dannf dot org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: systemtap at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-28923-6586-wjZBfxXYM8@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-28923-6586@http.sourceware.org/bugzilla/>
References: <bug-28923-6586@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: systemtap@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Systemtap mailing list <systemtap.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/systemtap>,
 <mailto:systemtap-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/systemtap/>
List-Help: <mailto:systemtap-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/systemtap>,
 <mailto:systemtap-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Fri, 25 Feb 2022 16:06:42 -0000

https://sourceware.org/bugzilla/show_bug.cgi?id=3D28923

--- Comment #2 from dann frazier <dannf at dannf dot org> ---
Thanks for the response Frank!

I suspect the flock() approach could have unintended side-effects depending=
 on
the underlying filesystem. I don't have a specific example. Much like a
toddler's birthday party, it's just something I've learned is better to avo=
id
over the years.

I do like the idea of providing a salt to the mkstemp function. Although,
probably not with the content of the input file alone because, in the libvi=
rt
case, that input is actually the same. The passed-in path is unique though,=
 so
that would seem to work.

Just to make sure we're not reinventing the wheel, I reached out to the
reproducible builds folks to see if they know of a way to override .file wh=
en
generating C files:

https://lists.reproducible-builds.org/pipermail/rb-general/2022-February/00=
2489.html

I suggest we see if they have a better idea. Meanwhile, I'll try to PoC a
filename-seeded-mkstemp patch.

--=20
You are receiving this mail because:
You are the assignee for the bug.=