From: "mcermak at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sourceware.org
Subject: [Bug releng/29668] New: The make rpm target broken
Date: Tue, 11 Oct 2022 12:14:46 +0000 [thread overview]
Message-ID: <bug-29668-6586@http.sourceware.org/bugzilla/> (raw)
https://sourceware.org/bugzilla/show_bug.cgi?id=29668
Bug ID: 29668
Summary: The make rpm target broken
Product: systemtap
Version: unspecified
Status: NEW
Severity: normal
Priority: P2
Component: releng
Assignee: systemtap at sourceware dot org
Reporter: mcermak at redhat dot com
Target Milestone: ---
Created attachment 14392
--> https://sourceware.org/bugzilla/attachment.cgi?id=14392&action=edit
possible patch
The recent git_version related updates (a73db1bdee, 2899dcf6a5) break the `make
rpm` target. Thing is that git_version.sh doesn't find a git repo, and
generates:
/* No git repo found, probably building from dist tarball */
#undef GIT_REPO
Which, in this case, is a false assumption implicitly causing the following
build time error:
In file included from session.cxx:25:
session.cxx: In member function 'std::string
systemtap_session::version_string()':
version.h:13:49: error: 'GIT_PRETTY_REV' was not declared in this scope
13 | (STAP_EXTRA_VERSION[0] ? STAP_EXTRA_VERSION : GIT_PRETTY_REV)
| ^~~~~~~~~~~~~~
session.cxx:492:62: note: in expansion of macro 'STAP_EXTENDED_VERSION'
492 | return string (VERSION) + "/" + elfutils_version2 + ", " +
STAP_EXTENDED_VERSION;
|
^~~~~~~~~~~~~~~~~~~~~
make[3]: *** [Makefile:1216: stap-session.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[3]: Leaving directory '/home/stapbuilduser/rpmbuild/BUILD/systemtap-4.8'
make[2]: *** [Makefile:2135: all-recursive] Error 1
make[2]: Leaving directory '/home/stapbuilduser/rpmbuild/BUILD/systemtap-4.8'
make[1]: *** [Makefile:800: all] Error 2
make[1]: Leaving directory '/home/stapbuilduser/rpmbuild/BUILD/systemtap-4.8'
error: Bad exit status from /var/tmp/rpm-tmp.EAV0bE (%build)
--
You are receiving this mail because:
You are the assignee for the bug.
next reply other threads:[~2022-10-11 12:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-11 12:14 mcermak at redhat dot com [this message]
2022-10-11 14:43 ` [Bug releng/29668] " mcermak at redhat dot com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-29668-6586@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=systemtap@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).