From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 5AB353858C2D; Tue, 11 Oct 2022 12:14:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5AB353858C2D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1665490487; bh=kHz3PPpuAIX+qSfiGUs9R8JZU65IXjjvz7oTnOPRXA8=; h=From:To:Subject:Date:From; b=Ool+YXJhfzdmO2Hy/IlmOp4LPR4ZKWaoG2jEMjoA8GBqp16GLajPPiR2d9VIa60JA TpaTL+nTwr5Uib38zP/7K6HmIpR/1hBXlYQh2Jg7JvSxJOmNGQVIGjScEpF6BXlyeI i4jRgklWDukAGmDSb+jlEauGYy5HnFjRMqS/RbuM= From: "mcermak at redhat dot com" To: systemtap@sourceware.org Subject: [Bug releng/29668] New: The make rpm target broken Date: Tue, 11 Oct 2022 12:14:46 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: systemtap X-Bugzilla-Component: releng X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: mcermak at redhat dot com X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: systemtap at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter target_milestone attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://sourceware.org/bugzilla/show_bug.cgi?id=3D29668 Bug ID: 29668 Summary: The make rpm target broken Product: systemtap Version: unspecified Status: NEW Severity: normal Priority: P2 Component: releng Assignee: systemtap at sourceware dot org Reporter: mcermak at redhat dot com Target Milestone: --- Created attachment 14392 --> https://sourceware.org/bugzilla/attachment.cgi?id=3D14392&action=3Ded= it possible patch The recent git_version related updates (a73db1bdee, 2899dcf6a5) break the `= make rpm` target. Thing is that git_version.sh doesn't find a git repo, and generates: /* No git repo found, probably building from dist tarball */ #undef GIT_REPO Which, in this case, is a false assumption implicitly causing the following build time error: In file included from session.cxx:25: session.cxx: In member function 'std::string systemtap_session::version_string()': version.h:13:49: error: 'GIT_PRETTY_REV' was not declared in this scope 13 | (STAP_EXTRA_VERSION[0] ? STAP_EXTRA_VERSION : GIT_PRETTY_REV) | ^~~~~~~~~~~~~~ session.cxx:492:62: note: in expansion of macro 'STAP_EXTENDED_VERSION' 492 | return string (VERSION) + "/" + elfutils_version2 + ", " + STAP_EXTENDED_VERSION; |=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20 ^~~~~~~~~~~~~~~~~~~~~ make[3]: *** [Makefile:1216: stap-session.o] Error 1 make[3]: *** Waiting for unfinished jobs.... make[3]: Leaving directory '/home/stapbuilduser/rpmbuild/BUILD/systemtap-4.= 8' make[2]: *** [Makefile:2135: all-recursive] Error 1 make[2]: Leaving directory '/home/stapbuilduser/rpmbuild/BUILD/systemtap-4.= 8' make[1]: *** [Makefile:800: all] Error 2 make[1]: Leaving directory '/home/stapbuilduser/rpmbuild/BUILD/systemtap-4.= 8' error: Bad exit status from /var/tmp/rpm-tmp.EAV0bE (%build) --=20 You are receiving this mail because: You are the assignee for the bug.=