From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
	id ABE583858002; Wed,  9 Nov 2022 12:57:23 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org ABE583858002
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org;
	s=default; t=1667998643;
	bh=3iapF+k+4StdWGbot258qKVIOfsgAOczkHxMRdnXYP0=;
	h=From:To:Subject:Date:From;
	b=oiyY0w8/OfF3fGiig8VVTWrO0UCRD0JwhudBmPWP5WYEINBr0zmPWTZSprjaVmau4
	 hwtTSJ9TsEEXehXeOLSh+83cELFVNEROeHiW7GLp4yhNLt953FffBq0RGfHEpXxp+q
	 5NL6b/7Bxr629JOq4LdjulUjQi+Xy4XuMXtnFjto=
From: "mcermak at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sourceware.org
Subject: [Bug runtime/29765] New: Convert NFS from readpages to readahead =>
 tapset/linux/nfs.stp breakage
Date: Wed, 09 Nov 2022 12:57:17 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: systemtap
X-Bugzilla-Component: runtime
X-Bugzilla-Version: unspecified
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: mcermak at redhat dot com
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: systemtap at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status
 bug_severity priority component assigned_to reporter target_milestone
Message-ID: <bug-29765-6586@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <systemtap.sourceware.org>

https://sourceware.org/bugzilla/show_bug.cgi?id=3D29765

            Bug ID: 29765
           Summary: Convert NFS from readpages to readahead =3D>
                    tapset/linux/nfs.stp breakage
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: runtime
          Assignee: systemtap at sourceware dot org
          Reporter: mcermak at redhat dot com
  Target Milestone: ---

Kernel commit 8786fde84 (Convert NFS from readpages to readahead) breaks the
tapset/linux/nfs.stp (stap commit 7eed8d1fe):

semantic error: while resolving probe point: identifier 'module' at
/usr/local/share/systemtap/tapset/linux/nfs.stp:976:27
        source:                           module("nfs").function
("nfs_readpages")

Linux kernel change:

commit 8786fde8421ce755a842051f9528674a1b1f0b9a
Author: Matthew Wilcox (Oracle) <willy@infradead.org>
Date:   Sat Jan 22 20:54:52 2022 +0000

    Convert NFS from readpages to readahead

    NFS is one of the last two users of the deprecated ->readpages aop.
    This conversion looks straightforward, but I have only compile-tested
    it.tapset/linux/nfs.stp=20=20

    Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
    Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>


Reproducer using 5.14.0-186.kpq1.el9:

# cat readpages.stp=20
probe nfs.aop.readpages {
        log(name);
        printf("dev=3D%d\n", dev);
        printf("ino=3D%d\n", ino);
        printf("nr_pages=3D%d\n", nr_pages);
        printf("file=3D%d\n", file);
        printf("rpages=3D%d\n", rpages);
        printf("rsize=3D%d\n", rsize);
        printf("argstr=3D%s\n", argstr);
        printf("size=3D%d\n", size);
        printf("units=3D%s\n", units);
}

probe nfs.aop.readpages.return {
        log(name);
        printf("retstr=3D%s\n", retstr);
        printf("size=3D%d\n", size);
        printf("units=3D%s\n", units);
}
# stap -vp4 readpages.stp=20
Pass 1: parsed user script and 472 library scripts using
123716virt/102716res/8432shr/94144data kb, in 570usr/120sys/910real ms.
semantic error: while resolving probe point: identifier 'module' at
/usr/local/share/systemtap/tapset/linux/nfs.stp:976:27
        source:                           module("nfs").function
("nfs_readpages")
                                          ^

semantic error: no match (similar functions: nfs_readpage, nfs_readahead,
nfs_writepages, nfs_readdir, nfs_readpage_done)

semantic error: resolution failed in alias expansion builder

semantic error: while resolving probe point: identifier 'nfs' at
readpages.stp:1:7
        source: probe nfs.aop.readpages {
                      ^

semantic error: no match

semantic error: while resolving probe point: identifier 'module' at
/usr/local/share/systemtap/tapset/linux/nfs.stp:995:34
        source:                                  module("nfs").function
("nfs_readpages").return
                                                 ^

semantic error: resolution failed in alias expansion builder

Pass 2: analyzed script: 0 probes, 0 functions, 0 embeds, 0 globals using
190100virt/170936res/10092shr/160528data kb, in 2250usr/650sys/2903real ms.
Pass 2: analysis failed.  [man error::pass2]
#

--=20
You are receiving this mail because:
You are the assignee for the bug.=