From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 5B5EF3853D65; Thu, 17 Nov 2022 19:19:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5B5EF3853D65 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1668712796; bh=ZGE+p3pYcBXpwkOiZ33cCPPITt5DJY7tbfIe51nZe+U=; h=From:To:Subject:Date:From; b=fm8pcuSbPpIRjJacGNRfjV8voll19ncOmLeqKFUP3b9CYrDMnt9YxV4R8MRGBuCj2 ChyzhBZyMQIG1Bn5yBp3N1AgKVWq91/jJxaljZaxrwr6RRjnBhGYPdmITC0XoMnxyW jqEAtFW5BAD5jofaf1/f9BIJZe74UJvqf5kPkS6E= From: "rgoldber at redhat dot com" To: systemtap@sourceware.org Subject: [Bug translator/29801] New: --monitor mode gets 2 hits to procfs("monitor_control").write for every 1 write Date: Thu, 17 Nov 2022 19:19:56 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: systemtap X-Bugzilla-Component: translator X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: rgoldber at redhat dot com X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: systemtap at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter target_milestone Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://sourceware.org/bugzilla/show_bug.cgi?id=3D29801 Bug ID: 29801 Summary: --monitor mode gets 2 hits to procfs("monitor_control").write for every 1 write Product: systemtap Version: unspecified Status: NEW Severity: normal Priority: P2 Component: translator Assignee: systemtap at sourceware dot org Reporter: rgoldber at redhat dot com Target Milestone: --- When running monitor mode it looks like for every one write_command call th= ere are 2 hits to the procfs("monitor_control").write probe. This isn't really = an issue for things like resume and pause, but it causing an issue with quit, causing the module to lockup So it turns out that elaborate.cxx::monitor_mode_write derives the procfs w= rite probe and has it join(and init) the procfs_derived_probe_group. Which enrol= ls the probe (adding it to the write_probes set) Then in semantic_pass_optimize1 the probe is added to the group (and enroll= ed) again which causes the second copy of the probe to be added to write_probes (leading to the above issue) So to fix this I can either just remove the join_group in monitor_mode_write (or add some join_group internal conditional to avoid repeats) or I could d= o a non-null check on groups before joining them in semantic_pass_optimize1 (but this could result in new issues with probes which may rely on this underlyi= ng behavior but also would lead to the widest covering solution) Is their a preference for which fix I go with? --=20 You are receiving this mail because: You are the assignee for the bug.=