From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id BDD243858439; Fri, 6 Oct 2023 21:03:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BDD243858439 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1696626196; bh=JLGhEFZV33YLBaaFyvEXlN90Hj0ZLR03e2gj5kbDG8Y=; h=From:To:Subject:Date:In-Reply-To:References:From; b=hnbw4+t4CwTJ/UDyep/MLoP4xvyuTGx+fmldp345fD9G4t5WukbcajUJfR0WxOaR2 Tjkm11MlDWpYyMANgu6hJX07/OQywHWbRmD04GgxjbsvDi4w1QCJIiReKSdLSI4z93 3Q9R03E+b3/IYbxhXQS1eVpl/vedgUwUNSkpij3Y= From: "wcohen at redhat dot com" To: systemtap@sourceware.org Subject: =?UTF-8?B?W0J1ZyBydW50aW1lLzMwNDAxXSBzMzkweCBzcGVjaWZpYzogaW52?= =?UTF-8?B?YWxpZCBhcHBsaWNhdGlvbiBvZiDigJhzaXplb2bigJkgdG8gaW5jb21wbGV0?= =?UTF-8?B?ZSB0eXBlIOKAmHN0cnVjdCBzdGFja19mcmFtZeKAmQ==?= Date: Fri, 06 Oct 2023 21:03:16 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: systemtap X-Bugzilla-Component: runtime X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: wcohen at redhat dot com X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: systemtap at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://sourceware.org/bugzilla/show_bug.cgi?id=3D30401 William Cohen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wcohen at redhat dot com --- Comment #1 from William Cohen --- I investigationed why this is failing on rhel9 s390. The struct stack_frame was moved arch/s390/include/asm/processor.h to arch/s390/include/asm/stackframe.h by kernel git commit 78c98f9074135d3dab4e39544e0a537f92388fce Author: Martin Schwidefsky 2019-01-28 02:33:08 Committer: Martin Schwidefsky 2019-05-02 07:54:11 Parent: 1c705ad5efae9c712e763a47fbcc95b87b7347d2 (s390/opcodes: add missing instructions to the disassembler) Child: ec7bf4789d95a0053bac0dfa36fbefd8cc584eea (s390/ftrace: use HAVE_FUNCTION_GRAPH_RET_ADDR_PTR) Branches: master, remotes/origin/master, remotes/origin/mmu_gather-race-fix, remotes/origin/tty-splice, remotes/origin/x86-rep-insns, remotes/origin/x86-uaccess-cleanup, wcohen/gcc9 Follows: v5.1-rc2 Precedes: v5.2-rc1 s390/unwind: introduce stack unwind API Rework the dump_trace() stack unwinder interface to support different unwinding algorithms. The new interface looks like this: struct unwind_state state; unwind_for_each_frame(&state, task, regs, start_stack) do_something(state.sp, state.ip, state.reliable); The unwind_bc.c file contains the implementation for the classic back-chain unwinder. One positive side effect of the new code is it now handles ftraced functions gracefully. It prints the real name of the return function instead of 'return_to_handler'. Signed-off-by: Martin Schwidefsky I am looking around to see there is a common include that ends up pulling in the definition of struct stack_frame. The patch above adds "#include " a number of files. Might need to resort to a STAPCONF = to add the include where needed. --=20 You are receiving this mail because: You are the assignee for the bug.=