From: "agentzh at gmail dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sourceware.org
Subject: [Bug runtime/30405] Kernel errors with Fedora 36's 6.2.12 debug kernels
Date: Sun, 30 Apr 2023 05:51:49 +0000 [thread overview]
Message-ID: <bug-30405-6586-AGoHKJGybF@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-30405-6586@http.sourceware.org/bugzilla/>
https://sourceware.org/bugzilla/show_bug.cgi?id=30405
--- Comment #1 from agentzh <agentzh at gmail dot com> ---
The following patch seems to fix the error itself:
```
diff --git a/runtime/linux/kprobes.c b/runtime/linux/kprobes.c
index c0f4f5c0f..72f4b148e 100644
--- a/runtime/linux/kprobes.c
+++ b/runtime/linux/kprobes.c
@@ -819,9 +819,7 @@ stapkp_init(struct stap_kprobe_probe *probes,
#ifdef STAPCONF_MODULE_MUTEX
mutex_lock(&module_mutex);
#endif
- preempt_disable();
kallsyms_on_each_symbol(stapkp_symbol_callback, &sd);
- preempt_enable();
#ifdef STAPCONF_MODULE_MUTEX
mutex_unlock(&module_mutex);
#endif
```
But it seems to effectively revert the previous commit for fixing a softlockup
in PR20735:
```
commit 58c9bd1563aece0c020d9c8da5cf8db8ef028439
Author: David Smith <dsmith@redhat.com>
Date: Thu Nov 10 09:59:16 2016 -0600
Fix PR20735 by updating kprobes.c to avoid a soft lockup.
* runtime/linux/kprobes.c: Instead of grabbing the module mutex around
calling kallsyms_on_each_symbol(), just disable/enable preemption
instead to avoid a soft lockup.
```
What should we do then?
--
You are receiving this mail because:
You are the assignee for the bug.
next prev parent reply other threads:[~2023-04-30 5:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-29 22:03 [Bug runtime/30405] New: " agentzh at gmail dot com
2023-04-30 5:51 ` agentzh at gmail dot com [this message]
2023-04-30 21:27 ` [Bug runtime/30405] Kernel errors in kallsyms_on_each_symbol() " agentzh at gmail dot com
2023-05-02 22:44 ` [Bug runtime/30405] Kernel errors in kallsyms_on_each_symbol() with Fedora 36's 6.2/6.1 " agentzh at gmail dot com
2023-05-02 22:45 ` agentzh at gmail dot com
2023-05-06 22:23 ` agentzh at gmail dot com
2023-05-09 19:53 ` agentzh at gmail dot com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-30405-6586-AGoHKJGybF@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=systemtap@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).