public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: "mcermak at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sourceware.org
Subject: [Bug runtime/30415] conflicting types for ‘kallsyms_on_each_symbol’
Date: Fri, 26 May 2023 10:28:23 +0000	[thread overview]
Message-ID: <bug-30415-6586-17qsiniV1I@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-30415-6586@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=30415

--- Comment #10 from Martin Cermak <mcermak at redhat dot com> ---
Gotcha (probably ;) so since module_kallsyms_on_each_symbol() isn't exported
just like kallsyms_on_each_symbol() isn't, and since starting from kernel
commit 013c1667cf78c1d847152f7116436d82dcab3db4
module_kallsyms_on_each_symbol() isn't called from kallsyms_on_each_symbol(),
we basically need to duplicate most of the kallsyms_on_each_symbol() related
logic (mostly in runtime/ and staprun/) in order to tap
module_kallsyms_on_each_symbol() just like kallsyms_on_each_symbol() is tapped
(via send_a_relocation() in staprun)..

Not sure yet what to do about the non-uniqueness of the symbols, but I assume
this is not a new problem, so something in the existing code needs to already
address this to some extent, and the new code can follow that model..

-- 
You are receiving this mail because:
You are the assignee for the bug.

  parent reply	other threads:[~2023-05-26 10:28 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-03  8:56 [Bug runtime/30415] New: " mcermak at redhat dot com
2023-05-03  9:01 ` [Bug runtime/30415] " mcermak at redhat dot com
2023-05-03 10:41 ` mcermak at redhat dot com
2023-05-09 19:23 ` wcohen at redhat dot com
2023-05-22  8:56 ` mcermak at redhat dot com
2023-05-22 14:01 ` wcohen at redhat dot com
2023-05-22 14:48 ` wcohen at redhat dot com
2023-05-24 11:16 ` mcermak at redhat dot com
2023-05-24 11:24 ` mcermak at redhat dot com
2023-05-25 18:43 ` wcohen at redhat dot com
2023-05-26 10:28 ` mcermak at redhat dot com [this message]
2023-05-30 14:51 ` mcermak at redhat dot com
2023-05-31 13:59 ` wcohen at redhat dot com
2023-06-02  9:28 ` mcermak at redhat dot com
2023-06-02 15:22 ` wcohen at redhat dot com
2023-06-02 18:26 ` mcermak at redhat dot com
2023-06-02 21:21 ` wcohen at redhat dot com
2023-06-02 21:38 ` mcermak at redhat dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-30415-6586-17qsiniV1I@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=systemtap@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).